Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_view_host_impl.h" 5 #include "content/browser/renderer_host/render_view_host_impl.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 983 matching lines...) Expand 10 before | Expand all | Expand 10 after
994 blink::WebPopupType popup_type) { 994 blink::WebPopupType popup_type) {
995 delegate_->CreateNewWidget(GetProcess()->GetID(), route_id, popup_type); 995 delegate_->CreateNewWidget(GetProcess()->GetID(), route_id, popup_type);
996 } 996 }
997 997
998 void RenderViewHostImpl::CreateNewFullscreenWidget(int route_id) { 998 void RenderViewHostImpl::CreateNewFullscreenWidget(int route_id) {
999 delegate_->CreateNewFullscreenWidget(GetProcess()->GetID(), route_id); 999 delegate_->CreateNewFullscreenWidget(GetProcess()->GetID(), route_id);
1000 } 1000 }
1001 1001
1002 void RenderViewHostImpl::OnShowView(int route_id, 1002 void RenderViewHostImpl::OnShowView(int route_id,
1003 WindowOpenDisposition disposition, 1003 WindowOpenDisposition disposition,
1004 const gfx::Rect& initial_pos, 1004 const gfx::Rect& initial_rect,
1005 bool user_gesture) { 1005 bool user_gesture) {
1006 if (is_active_) { 1006 if (is_active_) {
1007 delegate_->ShowCreatedWindow( 1007 delegate_->ShowCreatedWindow(
1008 route_id, disposition, initial_pos, user_gesture); 1008 route_id, disposition, initial_rect, user_gesture);
1009 } 1009 }
1010 Send(new ViewMsg_Move_ACK(route_id)); 1010 Send(new ViewMsg_Move_ACK(route_id));
1011 } 1011 }
1012 1012
1013 void RenderViewHostImpl::OnShowWidget(int route_id, 1013 void RenderViewHostImpl::OnShowWidget(int route_id,
1014 const gfx::Rect& initial_pos) { 1014 const gfx::Rect& initial_rect) {
1015 if (is_active_) 1015 if (is_active_)
1016 delegate_->ShowCreatedWidget(route_id, initial_pos); 1016 delegate_->ShowCreatedWidget(route_id, initial_rect);
1017 Send(new ViewMsg_Move_ACK(route_id)); 1017 Send(new ViewMsg_Move_ACK(route_id));
1018 } 1018 }
1019 1019
1020 void RenderViewHostImpl::OnShowFullscreenWidget(int route_id) { 1020 void RenderViewHostImpl::OnShowFullscreenWidget(int route_id) {
1021 if (is_active_) 1021 if (is_active_)
1022 delegate_->ShowCreatedFullscreenWidget(route_id); 1022 delegate_->ShowCreatedFullscreenWidget(route_id);
1023 Send(new ViewMsg_Move_ACK(route_id)); 1023 Send(new ViewMsg_Move_ACK(route_id));
1024 } 1024 }
1025 1025
1026 void RenderViewHostImpl::OnRunModal(int opener_id, IPC::Message* reply_msg) { 1026 void RenderViewHostImpl::OnRunModal(int opener_id, IPC::Message* reply_msg) {
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
1472 FrameTree* frame_tree = delegate_->GetFrameTree(); 1472 FrameTree* frame_tree = delegate_->GetFrameTree();
1473 1473
1474 frame_tree->ResetForMainFrameSwap(); 1474 frame_tree->ResetForMainFrameSwap();
1475 } 1475 }
1476 1476
1477 void RenderViewHostImpl::SelectWordAroundCaret() { 1477 void RenderViewHostImpl::SelectWordAroundCaret() {
1478 Send(new ViewMsg_SelectWordAroundCaret(GetRoutingID())); 1478 Send(new ViewMsg_SelectWordAroundCaret(GetRoutingID()));
1479 } 1479 }
1480 1480
1481 } // namespace content 1481 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_view_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698