android_webview/native/aw_web_contents_delegate.cc - Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_web_contents_delegate.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/native/aw_web_contents_delegate.cc

diff --git a/android_webview/native/aw_web_contents_delegate.cc b/android_webview/native/aw_web_contents_delegate.cc

index 2f43de1ae6d25a2e81966a85ee4b7c7aff17e0e1..acece1bf63e245fab3344e72cb01fed5e16c447e 100644

--- a/android_webview/native/aw_web_contents_delegate.cc

+++ b/android_webview/native/aw_web_contents_delegate.cc

@@ -125,7 +125,7 @@ void AwWebContentsDelegate::RunFileChooser(WebContents* web_contents,

void AwWebContentsDelegate::AddNewContents(WebContents* source,

WebContents* new_contents,

WindowOpenDisposition disposition,

- const gfx::Rect& initial_pos,

+ const gfx::Rect& initial_rect,

bool user_gesture,

bool* was_blocked) {

JNIEnv* env = AttachCurrentThread();

« no previous file with comments | « android_webview/native/aw_web_contents_delegate.h ('k') | apps/custom_launcher_page_contents.h » ('j') | no next file with comments »