chrome/browser/ui/browser_tabstrip.cc - Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_tabstrip.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_tabstrip.cc

diff --git a/chrome/browser/ui/browser_tabstrip.cc b/chrome/browser/ui/browser_tabstrip.cc

index b307c93ac26835198b4ece6622c3ee8a3e4704e6..bb20e62e9572313eb0bcb3dd64e3735f1a859fb4 100644

--- a/chrome/browser/ui/browser_tabstrip.cc

+++ b/chrome/browser/ui/browser_tabstrip.cc

@@ -48,7 +48,7 @@ void AddWebContents(Browser* browser,

content::WebContents* source_contents,

content::WebContents* new_contents,

WindowOpenDisposition disposition,

- const gfx::Rect& initial_pos,

+ const gfx::Rect& initial_rect,

bool user_gesture,

bool* was_blocked) {

// No code for this yet.

@@ -59,7 +59,7 @@ void AddWebContents(Browser* browser,

NavigateParams params(browser, new_contents);

params.source_contents = source_contents;

params.disposition = disposition;

- params.window_bounds = initial_pos;

+ params.window_bounds = initial_rect;

params.window_action = NavigateParams::SHOW_WINDOW;

// At this point, we're already beyond the popup blocker. Even if the popup

// was created without a user gesture, we have to set |user_gesture| to true,

« no previous file with comments | « chrome/browser/ui/browser_tabstrip.h ('k') | chrome/browser/ui/cocoa/web_dialog_window_controller.mm » ('j') | no next file with comments »