Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/interstitial_page_impl.h" 5 #include "content/browser/frame_host/interstitial_page_impl.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 722 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 } 733 }
734 734
735 void InterstitialPageImpl::CreateNewFullscreenWidget(int render_process_id, 735 void InterstitialPageImpl::CreateNewFullscreenWidget(int render_process_id,
736 int route_id) { 736 int route_id) {
737 NOTREACHED() 737 NOTREACHED()
738 << "InterstitialPage does not support showing full screen popups."; 738 << "InterstitialPage does not support showing full screen popups.";
739 } 739 }
740 740
741 void InterstitialPageImpl::ShowCreatedWindow(int route_id, 741 void InterstitialPageImpl::ShowCreatedWindow(int route_id,
742 WindowOpenDisposition disposition, 742 WindowOpenDisposition disposition,
743 const gfx::Rect& initial_pos, 743 const gfx::Rect& initial_rect,
744 bool user_gesture) { 744 bool user_gesture) {
745 NOTREACHED() << "InterstitialPage does not support showing popups yet."; 745 NOTREACHED() << "InterstitialPage does not support showing popups yet.";
746 } 746 }
747 747
748 void InterstitialPageImpl::ShowCreatedWidget(int route_id, 748 void InterstitialPageImpl::ShowCreatedWidget(int route_id,
749 const gfx::Rect& initial_pos) { 749 const gfx::Rect& initial_rect) {
750 NOTREACHED() << "InterstitialPage does not support showing drop-downs yet."; 750 NOTREACHED() << "InterstitialPage does not support showing drop-downs yet.";
751 } 751 }
752 752
753 void InterstitialPageImpl::ShowCreatedFullscreenWidget(int route_id) { 753 void InterstitialPageImpl::ShowCreatedFullscreenWidget(int route_id) {
754 NOTREACHED() 754 NOTREACHED()
755 << "InterstitialPage does not support showing full screen popups."; 755 << "InterstitialPage does not support showing full screen popups.";
756 } 756 }
757 757
758 SessionStorageNamespace* InterstitialPageImpl::GetSessionStorageNamespace( 758 SessionStorageNamespace* InterstitialPageImpl::GetSessionStorageNamespace(
759 SiteInstance* instance) { 759 SiteInstance* instance) {
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
904 void InterstitialPageImpl::UnderlyingContentObserver::NavigationEntryCommitted( 904 void InterstitialPageImpl::UnderlyingContentObserver::NavigationEntryCommitted(
905 const LoadCommittedDetails& load_details) { 905 const LoadCommittedDetails& load_details) {
906 interstitial_->OnNavigatingAwayOrTabClosing(); 906 interstitial_->OnNavigatingAwayOrTabClosing();
907 } 907 }
908 908
909 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() { 909 void InterstitialPageImpl::UnderlyingContentObserver::WebContentsDestroyed() {
910 interstitial_->OnNavigatingAwayOrTabClosing(); 910 interstitial_->OnNavigatingAwayOrTabClosing();
911 } 911 }
912 912
913 } // namespace content 913 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.h ('k') | content/browser/frame_host/render_widget_host_view_child_frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698