Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: ui/web_dialogs/web_dialog_delegate.h

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/web_dialogs/test/test_web_contents_handler.cc ('k') | ui/web_dialogs/web_dialog_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/web_dialogs/web_dialog_delegate.h
diff --git a/ui/web_dialogs/web_dialog_delegate.h b/ui/web_dialogs/web_dialog_delegate.h
index 898b04513d416765bead45344e6eb560028e3dbd..6d2079d35ad2cab461b4391ebb7287f07833a12f 100644
--- a/ui/web_dialogs/web_dialog_delegate.h
+++ b/ui/web_dialogs/web_dialog_delegate.h
@@ -120,13 +120,13 @@ class WEB_DIALOGS_EXPORT WebDialogDelegate {
// A callback to create a new tab with |new_contents|. |source| is the
// WebContent where the operation originated. |disposition| controls how the
- // new tab should be opened. |initial_pos| is the position of the window if a
- // new window is created. |user_gesture| is true if the operation was started
- // by a user gesture. Return false to use the default handler.
+ // new tab should be opened. |initial_rect| is the position and size of the
+ // window if a new window is created. |user_gesture| is true if the operation
+ // was started by a user gesture. Return false to use the default handler.
virtual bool HandleAddNewContents(content::WebContents* source,
content::WebContents* new_contents,
WindowOpenDisposition disposition,
- const gfx::Rect& initial_pos,
+ const gfx::Rect& initial_rect,
bool user_gesture);
// A callback to control whether a WebContents will be created. Returns
« no previous file with comments | « ui/web_dialogs/test/test_web_contents_handler.cc ('k') | ui/web_dialogs/web_dialog_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698