Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 788733003: Make addUniform take a precision (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@move_prec
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : fix non-arrays #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -143 lines) Patch
M include/gpu/GrShaderVar.h View 7 chunks +7 lines, -0 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 2 chunks +17 lines, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 3 2 chunks +11 lines, -6 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 8 chunks +23 lines, -16 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +12 lines, -6 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 5 chunks +14 lines, -7 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 5 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 2 chunks +29 lines, -28 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 6 chunks +15 lines, -21 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
The real changes are in GrGLShaderBuilder.* and Gr[GL]ShaderVar.h. The rest is just updating call sites ...
6 years ago (2014-12-08 22:59:13 UTC) #2
bsalomon
On 2014/12/08 22:59:13, bsalomon wrote: > The real changes are in GrGLShaderBuilder.* and Gr[GL]ShaderVar.h. The ...
6 years ago (2014-12-08 22:59:38 UTC) #3
joshualitt
On 2014/12/08 22:59:38, bsalomon wrote: > On 2014/12/08 22:59:13, bsalomon wrote: > > The real ...
6 years ago (2014-12-09 14:50:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788733003/60001
6 years ago (2014-12-09 18:08:36 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-09 18:18:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/422f56f6e51c2f6a6ab425573b4d790f0157f883

Powered by Google App Engine
This is Rietveld 408576698