src/effects/SkArithmeticMode.cpp - Issue 788733003: Make addUniform take a precision

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkArithmeticMode.cpp

Issue 788733003: Make addUniform take a precision (Closed) Base URL: https://skia.googlesource.com/skia.git@move_prec

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkArithmeticMode.cpp

diff --git a/src/effects/SkArithmeticMode.cpp b/src/effects/SkArithmeticMode.cpp

index 240173b3155121fc5261fa70f44356caf5acadaa..a1f14ec1cb4ccdb7f30604c142599c83a23bfb25 100644

--- a/src/effects/SkArithmeticMode.cpp

+++ b/src/effects/SkArithmeticMode.cpp

@@ -371,7 +371,8 @@ void GrGLArithmeticEffect::emitCode(GrGLFPBuilder* builder,

SkASSERT(dstColor);

fKUni = builder->addUniform(GrGLProgramBuilder::kFragment_Visibility,

- kVec4f_GrSLType, "k");

+ kVec4f_GrSLType, kDefault_GrSLPrecision,

+ "k");

const char* kUni = builder->getUniformCStr(fKUni);

// We don't try to optimize for this case at all

« no previous file with comments | « src/effects/SkAlphaThresholdFilter.cpp ('k') | src/effects/SkBlurMaskFilter.cpp » ('j') | no next file with comments »