Fix remaining WeakPtrFactory ordering problems

Fix remaining WeakPtrFactory ordering problems in preparation for turning on the check.

WeakPtrFactory members should always be last so that they invalidate WeakPtrs prior to other destructors running. These are mostly trivial/mechanical ones.

(We'll also need https://codereview.chromium.org/795003003/, which I split out)

BUG=303818
TBR=rockot,vitalybuka,cbentzel,shess,dmazzoni,stanisc,sky,tim,mathp,benjhayden,kinuko,scottmg,sergeyu,zork,ddorwin

Committed: https://crrev.com/23a804335e8955cac7825039ce3c40a8a23fc436
Cr-Commit-Position: refs/heads/master@{#308137}

[dmichael (off chromium), 2014-12-11 20:21:48]

dmichael@chromium.org changed reviewers:
+ thakis@chromium.org

[dmichael (off chromium), 2014-12-11 20:33:27]

If it lgty, I'll TBR some OWNERS

[Nico, 2014-12-11 23:58:45]

What about
https://code.google.com/p/chromium/codesearch#chromium/src/base/cancelable_ca...
?

[Nico, 2014-12-12 00:03:38]

this cl lgtm

https://codereview.chromium.org/780713002/diff/60001/content/renderer/media/r...
File content/renderer/media/remote_media_stream_impl.cc (right):

https://codereview.chromium.org/780713002/diff/60001/content/renderer/media/r...
content/renderer/media/remote_media_stream_impl.cc:356: observer_ = new
RemoteMediaStreamImpl::Observer(
heh :-)

https://codereview.chromium.org/780713002/diff/60001/extensions/browser/api/d...
File extensions/browser/api/declarative/rules_registry.h (left):

https://codereview.chromium.org/780713002/diff/60001/extensions/browser/api/d...
extensions/browser/api/declarative/rules_registry.h:264: // produce a pointer as
a construction argument for |cache_delegate_|.
please get approval from whoever wrote this comment

[dmichael (off chromium), 2014-12-12 16:57:03]

CancelableCallback is probably getting missed because it's a template. I'll take
a look to see how hard it would be to cover templates in the clang plugin... 
probably at instantiation time. If it's hard, it might not be worth covering
those.

Either way, I think this CL can go forward once I add OWNERS. Thanks so much for
the review!

https://codereview.chromium.org/780713002/diff/60001/extensions/browser/api/d...
File extensions/browser/api/declarative/rules_registry.h (left):

https://codereview.chromium.org/780713002/diff/60001/extensions/browser/api/d...
extensions/browser/api/declarative/rules_registry.h:264: // produce a pointer as
a construction argument for |cache_delegate_|.
On 2014/12/12 00:03:37, Nico wrote:
> please get approval from whoever wrote this comment
The comment was introduced here:
https://codereview.chromium.org/49693003/diff/320001/chrome/browser/extension...
became obsolete with this change:
https://codereview.chromium.org/53273002/diff/930001/chrome/browser/extension...
...but wasn't removed at that time.

I'll add fsamuel anyway, but I'm pretty confident it's safe to remove now.

[dmichael (off chromium), 2014-12-12 17:52:56]

dmichael@chromium.org changed reviewers:
+ fsamuel@chromium.org

[dmichael (off chromium), 2014-12-12 17:52:57]

fsamuel: Please see Nico's comment here:
https://codereview.chromium.org/780713002/diff/60001/extensions/browser/api/d...

OWNERS TBRs:
rockot: *extensions*
vitalybuka: chrome/browser/local_discovery/service_discovery_client_mdns.cc
cbentzel: chrome/browser/prerender
shess: chrome/browser/safe_browsing/download_protection_service.cc
dmazzoni: chrome/browser/speech/extension_api/tts_extension_apitest.cc
stanisc: *sync*
sky: chrome/browser/ui
tim: components/signin
mathp: components/suggestions
benjhayden: content/browser/download/download_browsertest.cc
kinuko: content/browser/fileapi
scottmg: content/browser/gamepad
sergeyu: content/browser/renderer_host/p2p
zork: content/browser/streams
ddorwin: *media*

[scottmg, 2014-12-12 18:00:00]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2014-12-12 18:00:00]

lgtm

[dmichael (off chromium), 2014-12-12 18:01:46]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2014-12-12 18:03:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/780713002/80001

[commit-bot: I haz the power, 2014-12-12 19:02:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-12-12 19:03:00]

Patchset 5 (id:??) landed as
https://crrev.com/23a804335e8955cac7825039ce3c40a8a23fc436
Cr-Commit-Position: refs/heads/master@{#308137}