chrome/browser/sync/sessions/session_data_type_controller_unittest.cc - Issue 780713002: Fix remaining WeakPtrFactory ordering problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sessions/session_data_type_controller_unittest.cc

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/speech/extension_api/tts_extension_apitest.cc ('k') | chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/sessions/session_data_type_controller_unittest.cc

diff --git a/chrome/browser/sync/sessions/session_data_type_controller_unittest.cc b/chrome/browser/sync/sessions/session_data_type_controller_unittest.cc

index f894d39fd7398ec7820c2d9b9ab2099a109ad149..b42700390688b0e3067d8444804ed18c5b0f7034 100644

--- a/chrome/browser/sync/sessions/session_data_type_controller_unittest.cc

+++ b/chrome/browser/sync/sessions/session_data_type_controller_unittest.cc

@@ -83,8 +83,8 @@ class SessionDataTypeControllerTest

SessionDataTypeControllerTest()

: load_finished_(false),

thread_bundle_(content::TestBrowserThreadBundle::DEFAULT),

- weak_ptr_factory_(this),

- last_type_(syncer::UNSPECIFIED) {}

+ last_type_(syncer::UNSPECIFIED),

+ weak_ptr_factory_(this) {}

~SessionDataTypeControllerTest() override {}

void SetUp() override {

@@ -162,9 +162,9 @@ class SessionDataTypeControllerTest

content::TestBrowserThreadBundle thread_bundle_;

ProfileSyncComponentsFactoryMock profile_sync_factory_;

TestingProfile profile_;

- base::WeakPtrFactory<SessionDataTypeControllerTest> weak_ptr_factory_;

syncer::ModelType last_type_;

syncer::SyncError last_error_;

+ base::WeakPtrFactory<SessionDataTypeControllerTest> weak_ptr_factory_;

};

TEST_F(SessionDataTypeControllerTest, StartModels) {