Fix remaining WeakPtrFactory ordering problems

components/sync_driver/device_info_data_type_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "components/sync_driver/device_info_data_type_controller.h"
 #include "components/sync_driver/local_device_info_provider_mock.h"
 #include "components/sync_driver/sync_api_component_factory.h"
 #include "sync/internal_api/public/base/model_type.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace sync_driver {
 
 namespace {
 
 class DeviceInfoDataTypeControllerTest : public testing::Test,
                                          public SyncApiComponentFactory {
  public:
   DeviceInfoDataTypeControllerTest()
       : load_finished_(false),
-        weak_ptr_factory_(this),
-        last_type_(syncer::UNSPECIFIED) {}
+        last_type_(syncer::UNSPECIFIED),
+        weak_ptr_factory_(this) {}
   ~DeviceInfoDataTypeControllerTest() override {}
 
   void SetUp() override {
     local_device_.reset(new LocalDeviceInfoProviderMock(
         "cache_guid",
         "Wayne Gretzky's Hacking Box",
         "Chromium 10k",
         "Chrome 10k",
         sync_pb::SyncEnums_DeviceType_TYPE_LINUX,
         "device_id"));
@@ skipping 64 matching lines @@
     return testing::AssertionSuccess();
   }
 
  protected:
   scoped_refptr<DeviceInfoDataTypeController> controller_;
   scoped_ptr<LocalDeviceInfoProviderMock> local_device_;
   bool load_finished_;
 
  private:
   base::MessageLoopForUI message_loop_;
-  base::WeakPtrFactory<DeviceInfoDataTypeControllerTest> weak_ptr_factory_;
   syncer::ModelType last_type_;
   syncer::SyncError last_error_;
+  base::WeakPtrFactory<DeviceInfoDataTypeControllerTest> weak_ptr_factory_;
 };
 
 TEST_F(DeviceInfoDataTypeControllerTest, StartModels) {
   Start();
   EXPECT_EQ(DataTypeController::MODEL_LOADED, controller_->state());
   EXPECT_TRUE(LoadResult());
 }
 
 TEST_F(DeviceInfoDataTypeControllerTest, StartModelsDelayedByLocalDevice) {
   local_device_->SetInitialized(false);
@@ skipping 15 matching lines @@
   controller_->Stop();
   // Destroy |local_device_| and |controller_| out of order
   // to verify that the controller doesn't crash in the destructor.
   local_device_.reset();
   controller_ = NULL;
 }
 
 }  // namespace
 
 }  // namespace sync_driver