Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: components/signin/core/browser/signin_manager.h

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_manager.h
diff --git a/components/signin/core/browser/signin_manager.h b/components/signin/core/browser/signin_manager.h
index 04b645ac67488a5394641e1b81668ad1d9e1297c..47e70d071b46cf0daba1ea160e1ed8ac6518b829 100644
--- a/components/signin/core/browser/signin_manager.h
+++ b/components/signin/core/browser/signin_manager.h
@@ -226,14 +226,14 @@ class SigninManager : public SigninManagerBase,
// Helper to merge signed in account into the content area.
scoped_ptr<MergeSessionHelper> merge_session_helper_;
- base::WeakPtrFactory<SigninManager> weak_pointer_factory_;
-
// Two gate conditions for when PostSignedIn should be called. Verify
// that the SigninManager has reached OnSignedIn() and the AccountTracker
// has completed calling GetUserInfo.
bool signin_manager_signed_in_;
bool user_info_fetched_by_account_tracker_;
+ base::WeakPtrFactory<SigninManager> weak_pointer_factory_;
+
DISALLOW_COPY_AND_ASSIGN(SigninManager);
};
« no previous file with comments | « chrome/browser/ui/webui/signin/user_manager_screen_handler.h ('k') | components/signin/core/browser/signin_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698