content/browser/streams/stream_url_request_job.cc - Issue 780713002: Fix remaining WeakPtrFactory ordering problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/streams/stream_url_request_job.cc

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/streams/stream_url_request_job.cc

diff --git a/content/browser/streams/stream_url_request_job.cc b/content/browser/streams/stream_url_request_job.cc

index 6d70eefa515d437746e02129112d4d095f384387..3d4ac7f77f0476d85a093f3cf6b27bc996ef65f2 100644

--- a/content/browser/streams/stream_url_request_job.cc

+++ b/content/browser/streams/stream_url_request_job.cc

@@ -21,13 +21,13 @@ StreamURLRequestJob::StreamURLRequestJob(

net::NetworkDelegate* network_delegate,

scoped_refptr<Stream> stream)

: net::URLRequestJob(request, network_delegate),

- weak_factory_(this),

stream_(stream),

headers_set_(false),

pending_buffer_size_(0),

total_bytes_read_(0),

max_range_(0),

- request_failed_(false) {

+ request_failed_(false),

+ weak_factory_(this) {

DCHECK(stream_.get());

stream_->SetReadObserver(this);

}