Fix remaining WeakPtrFactory ordering problems

extensions/browser/api/declarative/rules_registry.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_DECLARATIVE_RULES_REGISTRY_H__
 #define EXTENSIONS_BROWSER_API_DECLARATIVE_RULES_REGISTRY_H__
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 242 matching lines @@
 
   // Same as RemoveUsedRuleIdentifiers but operates on all rules of
   // |extension_id|.
   void RemoveAllUsedRuleIdentifiers(const std::string& extension_id);
 
   typedef std::string RuleIdentifier;
   typedef std::map<ExtensionId, std::set<RuleIdentifier> > RuleIdentifiersMap;
   RuleIdentifiersMap used_rule_identifiers_;
   int last_generated_rule_identifier_id_;
 
-  // The factory needs to be declared before |cache_delegate_|, so that it can
-  // produce a pointer as a construction argument for |cache_delegate_|.

[Nico, 2014/12/12 00:03:37]

please get approval from whoever wrote this comment

[dmichael (off chromium), 2014/12/12 16:57:03]

The comment was introduced here:
https://codereview.chromium.org/49693003/diff/320001/chrome/browser/extension...
became obsolete with this change:
https://codereview.chromium.org/53273002/diff/930001/chrome/browser/extension...
...but wasn't removed at that time.

I'll add fsamuel anyway, but I'm pretty confident it's safe to remove now.

-  base::WeakPtrFactory<RulesRegistry> weak_ptr_factory_;
-
   // |cache_delegate_| is owned by the registry service. If |cache_delegate_| is
   // NULL, then the storage functionality is disabled (this is used in tests).
   // This registry cannot own |cache_delegate_| because during the time after
   // rules registry service shuts down on UI thread, and the registry is
   // destroyed on its thread, the use of the |cache_delegate_| would not be
   // safe. The registry only ever associates with one RulesCacheDelegate
   // instance.
   base::WeakPtr<RulesCacheDelegate> cache_delegate_;
 
+  base::WeakPtrFactory<RulesRegistry> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(RulesRegistry);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_DECLARATIVE_RULES_REGISTRY_H__