Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: components/signin/core/browser/signin_manager.h

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // The signin manager encapsulates some functionality tracking 5 // The signin manager encapsulates some functionality tracking
6 // which user is signed in. See SigninManagerBase for full description of 6 // which user is signed in. See SigninManagerBase for full description of
7 // responsibilities. The class defined in this file provides functionality 7 // responsibilities. The class defined in this file provides functionality
8 // required by all platforms except Chrome OS. 8 // required by all platforms except Chrome OS.
9 // 9 //
10 // When a user is signed in, a ClientLogin request is run on their behalf. 10 // When a user is signed in, a ClientLogin request is run on their behalf.
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 // Helper object to listen for changes to signin preferences stored in non- 219 // Helper object to listen for changes to signin preferences stored in non-
220 // profile-specific local prefs (like kGoogleServicesUsernamePattern). 220 // profile-specific local prefs (like kGoogleServicesUsernamePattern).
221 PrefChangeRegistrar local_state_pref_registrar_; 221 PrefChangeRegistrar local_state_pref_registrar_;
222 222
223 // Helper object to listen for changes to the signin allowed preference. 223 // Helper object to listen for changes to the signin allowed preference.
224 BooleanPrefMember signin_allowed_; 224 BooleanPrefMember signin_allowed_;
225 225
226 // Helper to merge signed in account into the content area. 226 // Helper to merge signed in account into the content area.
227 scoped_ptr<MergeSessionHelper> merge_session_helper_; 227 scoped_ptr<MergeSessionHelper> merge_session_helper_;
228 228
229 base::WeakPtrFactory<SigninManager> weak_pointer_factory_;
230
231 // Two gate conditions for when PostSignedIn should be called. Verify 229 // Two gate conditions for when PostSignedIn should be called. Verify
232 // that the SigninManager has reached OnSignedIn() and the AccountTracker 230 // that the SigninManager has reached OnSignedIn() and the AccountTracker
233 // has completed calling GetUserInfo. 231 // has completed calling GetUserInfo.
234 bool signin_manager_signed_in_; 232 bool signin_manager_signed_in_;
235 bool user_info_fetched_by_account_tracker_; 233 bool user_info_fetched_by_account_tracker_;
236 234
235 base::WeakPtrFactory<SigninManager> weak_pointer_factory_;
236
237 DISALLOW_COPY_AND_ASSIGN(SigninManager); 237 DISALLOW_COPY_AND_ASSIGN(SigninManager);
238 }; 238 };
239 239
240 #endif // !defined(OS_CHROMEOS) 240 #endif // !defined(OS_CHROMEOS)
241 241
242 #endif // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_MANAGER_H_ 242 #endif // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_MANAGER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/signin/user_manager_screen_handler.h ('k') | components/signin/core/browser/signin_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698