Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: components/sync_driver/device_info_data_type_controller_unittest.cc

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/suggestions/image_manager.h ('k') | content/browser/download/download_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_driver/device_info_data_type_controller_unittest.cc
diff --git a/components/sync_driver/device_info_data_type_controller_unittest.cc b/components/sync_driver/device_info_data_type_controller_unittest.cc
index 18e4a5b9649b9516f629d334d4538e80ad83e9e0..e1c4af334f879b61c3e85bb6f569c1dd2c249e62 100644
--- a/components/sync_driver/device_info_data_type_controller_unittest.cc
+++ b/components/sync_driver/device_info_data_type_controller_unittest.cc
@@ -22,8 +22,8 @@ class DeviceInfoDataTypeControllerTest : public testing::Test,
public:
DeviceInfoDataTypeControllerTest()
: load_finished_(false),
- weak_ptr_factory_(this),
- last_type_(syncer::UNSPECIFIED) {}
+ last_type_(syncer::UNSPECIFIED),
+ weak_ptr_factory_(this) {}
~DeviceInfoDataTypeControllerTest() override {}
void SetUp() override {
@@ -108,9 +108,9 @@ class DeviceInfoDataTypeControllerTest : public testing::Test,
private:
base::MessageLoopForUI message_loop_;
- base::WeakPtrFactory<DeviceInfoDataTypeControllerTest> weak_ptr_factory_;
syncer::ModelType last_type_;
syncer::SyncError last_error_;
+ base::WeakPtrFactory<DeviceInfoDataTypeControllerTest> weak_ptr_factory_;
};
TEST_F(DeviceInfoDataTypeControllerTest, StartModels) {
« no previous file with comments | « components/suggestions/image_manager.h ('k') | content/browser/download/download_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698