extensions/browser/api/hid/hid_device_manager.h - Issue 780713002: Fix remaining WeakPtrFactory ordering problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/hid/hid_device_manager.h

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/hid/hid_device_manager.h

diff --git a/extensions/browser/api/hid/hid_device_manager.h b/extensions/browser/api/hid/hid_device_manager.h

index 1b5be6e4f1edec5df667d62b731f418a68ef451e..e979693344567ddda4f32ccd65791652a0fb98e5 100644

--- a/extensions/browser/api/hid/hid_device_manager.h

+++ b/extensions/browser/api/hid/hid_device_manager.h

@@ -101,7 +101,6 @@ class HidDeviceManager : public BrowserContextKeyedAPI,

const device::HidDeviceInfo& device_info);

base::ThreadChecker thread_checker_;

- base::WeakPtrFactory<HidDeviceManager> weak_factory_;

EventRouter* event_router_;

bool initialized_;

ScopedObserver<device::HidService, device::HidService::Observer>

@@ -111,6 +110,7 @@ class HidDeviceManager : public BrowserContextKeyedAPI,

int next_resource_id_;

ResourceIdToDeviceIdMap device_ids_;

DeviceIdToResourceIdMap resource_ids_;

+ base::WeakPtrFactory<HidDeviceManager> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(HidDeviceManager);

};