components/signin/core/browser/signin_manager.cc - Issue 780713002: Fix remaining WeakPtrFactory ordering problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_manager.cc

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/signin_manager.cc

diff --git a/components/signin/core/browser/signin_manager.cc b/components/signin/core/browser/signin_manager.cc

index 163204d4a4bcd9340d7fc85d48b5f3240e4fc1b2..9525df0037e54c70d92eaf93543a2acc5022d1be 100644

--- a/components/signin/core/browser/signin_manager.cc

+++ b/components/signin/core/browser/signin_manager.cc

@@ -68,9 +68,9 @@ SigninManager::SigninManager(SigninClient* client,

client_(client),

token_service_(token_service),

account_tracker_service_(account_tracker_service),

- weak_pointer_factory_(this),

signin_manager_signed_in_(false),

- user_info_fetched_by_account_tracker_(false) {}

+ user_info_fetched_by_account_tracker_(false),

+ weak_pointer_factory_(this) {}

void SigninManager::AddMergeSessionObserver(

MergeSessionHelper::Observer* observer) {