chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h - Issue 780713002: Fix remaining WeakPtrFactory ordering problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

index 1e0df0abb0d0a4a6d31fad4fe21f5f374ef95d22..d4a8efe4e33ac7e5e8a1c9b38051abac8dd0b25e 100644

--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

@@ -170,11 +170,11 @@ class RecentTabsSubMenuModel : public ui::SimpleMenuModel,

base::CancelableTaskTracker local_tab_cancelable_task_tracker_;

base::CancelableTaskTracker other_devices_tab_cancelable_task_tracker_;

- base::WeakPtrFactory<RecentTabsSubMenuModel> weak_ptr_factory_;

// Time the menu is open for until a recent tab is selected.

base::ElapsedTimer menu_opened_timer_;

+ base::WeakPtrFactory<RecentTabsSubMenuModel> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(RecentTabsSubMenuModel);

};