content/renderer/pepper/plugin_object.h - Issue 780713002: Fix remaining WeakPtrFactory ordering problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/plugin_object.h

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/plugin_object.h

diff --git a/content/renderer/pepper/plugin_object.h b/content/renderer/pepper/plugin_object.h

index f13fcd3570603872c16a098ca787b9d4a36ad63a..88b608e642a87b96ea55ec1d1856e98d70a00875 100644

--- a/content/renderer/pepper/plugin_object.h

+++ b/content/renderer/pepper/plugin_object.h

@@ -84,10 +84,10 @@ class PluginObject : public gin::Wrappable<PluginObject>,

const PPP_Class_Deprecated* ppp_class_;

void* ppp_class_data_;

- base::WeakPtrFactory<PluginObject> weak_factory_;

v8::StdPersistentValueMap<std::string, v8::FunctionTemplate> template_cache_;

+ base::WeakPtrFactory<PluginObject> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(PluginObject);

};