extensions/browser/api/hid/hid_device_manager.cc - Issue 780713002: Fix remaining WeakPtrFactory ordering problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/hid/hid_device_manager.cc

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/hid/hid_device_manager.cc

diff --git a/extensions/browser/api/hid/hid_device_manager.cc b/extensions/browser/api/hid/hid_device_manager.cc

index 757474f06771718004518432ef53557b46ef8410..5c84f8a904bd4eeb11128b997a2e24c791037cb9 100644

--- a/extensions/browser/api/hid/hid_device_manager.cc

+++ b/extensions/browser/api/hid/hid_device_manager.cc

@@ -77,11 +77,11 @@ struct HidDeviceManager::GetApiDevicesParams {

};

HidDeviceManager::HidDeviceManager(content::BrowserContext* context)

- : weak_factory_(this),

- initialized_(false),

+ : initialized_(false),

hid_service_observer_(this),

enumeration_ready_(false),

- next_resource_id_(0) {

+ next_resource_id_(0),

+ weak_factory_(this) {

event_router_ = EventRouter::Get(context);

if (event_router_) {

event_router_->RegisterObserver(this, hid::OnDeviceAdded::kEventName);