extensions/browser/api/serial/serial_connection.cc - Issue 780713002: Fix remaining WeakPtrFactory ordering problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/serial/serial_connection.cc

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/serial/serial_connection.cc

diff --git a/extensions/browser/api/serial/serial_connection.cc b/extensions/browser/api/serial/serial_connection.cc

index 7e95f5a6447625ecb67be1e26b8b91cbfc4524fd..1f42318b35ecded25dc8e0dab9fbd980bae4c904 100644

--- a/extensions/browser/api/serial/serial_connection.cc

+++ b/extensions/browser/api/serial/serial_connection.cc

@@ -380,7 +380,7 @@ void SerialConnection::OnAsyncWriteComplete(int bytes_sent,

SerialConnection::TimeoutTask::TimeoutTask(const base::Closure& closure,

const base::TimeDelta& delay)

- : weak_factory_(this), closure_(closure), delay_(delay) {

+ : closure_(closure), delay_(delay), weak_factory_(this) {

base::MessageLoop::current()->PostDelayedTask(

FROM_HERE,

base::Bind(&TimeoutTask::Run, weak_factory_.GetWeakPtr()),