content/renderer/media/remote_media_stream_impl.cc - Issue 780713002: Fix remaining WeakPtrFactory ordering problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/remote_media_stream_impl.cc

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/remote_media_stream_impl.cc

diff --git a/content/renderer/media/remote_media_stream_impl.cc b/content/renderer/media/remote_media_stream_impl.cc

index 1afd7f3d0b503690ff7d0704c3a010e4ca0feea8..5365251133e042caf419ed55dc7c84e455298376 100644

--- a/content/renderer/media/remote_media_stream_impl.cc

+++ b/content/renderer/media/remote_media_stream_impl.cc

@@ -352,9 +352,9 @@ RemoteMediaStreamImpl::RemoteMediaStreamImpl(

const scoped_refptr<base::SingleThreadTaskRunner>& main_thread,

webrtc::MediaStreamInterface* webrtc_stream)

: signaling_thread_(base::ThreadTaskRunnerHandle::Get()),

- weak_factory_(this),

- observer_(new RemoteMediaStreamImpl::Observer(weak_factory_.GetWeakPtr(),

- main_thread, webrtc_stream)) {

+ weak_factory_(this) {

+ observer_ = new RemoteMediaStreamImpl::Observer(

+ weak_factory_.GetWeakPtr(), main_thread, webrtc_stream);

CreateAdaptersForTracks(webrtc_stream->GetAudioTracks(),

&audio_track_observers_, main_thread);

CreateAdaptersForTracks(webrtc_stream->GetVideoTracks(),