|
Revert of Make the Sk GL context class an abstract base class (patchset #4 id:60001 of https://codereview.chromium.org/630843002/)
Reason for revert:
nanobech failing on Android
Original issue's description:
> Make the Sk GL context class an abstract base class
>
> Make the Sk GL context class, SkGLNativeContext, an abstract base class. Before,
> it depended on ifdefs to implement the platform dependent polymorphism. Move
> the logic to subclasses of the various platform implementations.
>
> This a step to enable Skia embedders to compile dm and bench_pictures. The
> concrete goal is to support running these test apps with Chromium command buffer.
>
> With this change, Chromium can implement its own version of SkGLNativeContext
> that uses command buffer, and host the implementation in its own repository.
>
> Implements the above by renaming the SkGLContextHelper to SkGLContext and
> removing the unneeded SkGLNativeContext. Also removes
> SkGLNativeContext::AutoRestoreContext functionality, it appeared to be unused:
> no use in Skia code, and no tests.
>
> BUG= skia:2992
>
> Committed: https://skia.googlesource.com/skia/+/a90ed4e83897b45d6331ee4c54e1edd4054de9a8
TBR=kkinnunen@nvidia.com
NOTREECHECKS=true
NOTRY=true
BUG= skia:2992
Committed: https://skia.googlesource.com/skia/+/10805961ce424868e8315e00f6dbeeaa62d466ac
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+1279 lines, -1240 lines) |
Patch |
|
M |
bench/nanobench.cpp
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
gyp/gpu.gypi
|
View
|
|
3 chunks |
+9 lines, -8 lines |
0 comments
|
Download
|
|
M |
gyp/public_headers.gypi
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
include/gpu/GrContextFactory.h
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
include/gpu/gl/SkANGLEGLContext.h
|
View
|
|
2 chunks |
+13 lines, -2 lines |
0 comments
|
Download
|
|
M |
include/gpu/gl/SkDebugGLContext.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
D |
include/gpu/gl/SkGLContext.h
|
View
|
|
1 chunk |
+0 lines, -103 lines |
0 comments
|
Download
|
|
A |
include/gpu/gl/SkGLContextHelper.h
|
View
|
|
1 chunk |
+95 lines, -0 lines |
0 comments
|
Download
|
|
M |
include/gpu/gl/SkMesaGLContext.h
|
View
|
|
2 chunks |
+15 lines, -2 lines |
0 comments
|
Download
|
|
A |
include/gpu/gl/SkNativeGLContext.h
|
View
|
|
1 chunk |
+111 lines, -0 lines |
0 comments
|
Download
|
|
M |
include/gpu/gl/SkNullGLContext.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
D |
src/gpu/gl/SkGLContext.cpp
|
View
|
|
1 chunk |
+0 lines, -142 lines |
0 comments
|
Download
|
|
A |
src/gpu/gl/SkGLContextHelper.cpp
|
View
|
|
1 chunk |
+142 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/gpu/gl/angle/SkANGLEGLContext.cpp
|
View
|
|
1 chunk |
+15 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/gpu/gl/debug/GrGLCreateDebugInterface.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
D |
src/gpu/gl/egl/SkCreatePlatformGLContext_egl.cpp
|
View
|
|
1 chunk |
+0 lines, -197 lines |
0 comments
|
Download
|
|
A |
src/gpu/gl/egl/SkNativeGLContext_egl.cpp
|
View
|
|
1 chunk |
+182 lines, -0 lines |
0 comments
|
Download
|
|
D |
src/gpu/gl/glx/SkCreatePlatformGLContext_glx.cpp
|
View
|
|
1 chunk |
+0 lines, -326 lines |
0 comments
|
Download
|
|
A |
src/gpu/gl/glx/SkNativeGLContext_glx.cpp
|
View
|
|
1 chunk |
+288 lines, -0 lines |
0 comments
|
Download
|
|
D |
src/gpu/gl/iOS/SkCreatePlatformGLContext_iOS.mm
|
View
|
|
1 chunk |
+0 lines, -81 lines |
0 comments
|
Download
|
|
A |
src/gpu/gl/iOS/SkNativeGLContext_iOS.mm
|
View
|
|
1 chunk |
+71 lines, -0 lines |
0 comments
|
Download
|
|
D |
src/gpu/gl/mac/SkCreatePlatformGLContext_mac.cpp
|
View
|
|
1 chunk |
+0 lines, -99 lines |
0 comments
|
Download
|
|
A |
src/gpu/gl/mac/SkNativeGLContext_mac.cpp
|
View
|
|
1 chunk |
+84 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/gpu/gl/mesa/SkMesaGLContext.cpp
|
View
|
|
1 chunk |
+18 lines, -0 lines |
0 comments
|
Download
|
|
D |
src/gpu/gl/nacl/SkCreatePlatformGLContext_nacl.cpp
|
View
|
|
1 chunk |
+0 lines, -60 lines |
0 comments
|
Download
|
|
A |
src/gpu/gl/nacl/SkNativeGLContext_nacl.cpp
|
View
|
|
1 chunk |
+37 lines, -0 lines |
0 comments
|
Download
|
|
D |
src/gpu/gl/win/SkCreatePlatformGLContext_win.cpp
|
View
|
|
1 chunk |
+0 lines, -187 lines |
0 comments
|
Download
|
|
A |
src/gpu/gl/win/SkNativeGLContext_win.cpp
|
View
|
|
1 chunk |
+165 lines, -0 lines |
0 comments
|
Download
|
|
M |
tests/GLInterfaceValidationTest.cpp
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
tests/Test.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
tools/PictureRenderer.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
tools/PictureRenderer.cpp
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
tools/timer/GpuTimer.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
tools/timer/GpuTimer.cpp
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
tools/timer/Timer.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
tools/timer/Timer.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|