cc: Move SkShader construction to a single spot in PaintShader

cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

BUG=728359
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2893083002
Cr-Original-Commit-Position: refs/heads/master@{#477810}
Committed: https://chromium.googlesource.com/chromium/src/+/cda52d0cc0fea52b996fce1663a8de5141fe48c3
Review-Url: https://codereview.chromium.org/2893083002
Cr-Commit-Position: refs/heads/master@{#478095}
Committed: https://chromium.googlesource.com/chromium/src/+/7b99c95846da32cdb1060f59a1a1f5bd27ab2696

[vmpstr, 2017-05-19 20:25:18]

Description was changed from

==========
wip: PaintShader

BUG=
==========

to

==========
wip: PaintShader

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[vmpstr, 2017-05-19 20:25:19]

Description was changed from

==========
wip: PaintShader

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
wip: PaintShader

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[vmpstr, 2017-05-19 22:59:21]

Description was changed from

==========
wip: PaintShader

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
wip: PaintShader

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[vmpstr, 2017-05-19 22:59:21]

vmpstr@chromium.org changed reviewers:
+ enne@chromium.org

[vmpstr, 2017-05-19 23:00:39]

This is kind of the approach I'm taking... Not sure if there are better ideas,
but the next step would be to make PaintShader keep its ctor arguments instead
of just building a shader, and move more shaders to that (like gradients)..

then store PaintShader on the flags, and only generate an skshader at raster.

[vmpstr, 2017-05-23 18:15:18]

PTAL. paint_shader.h ctors seems to be the minimum set of things that we
construct. This essentially removes SkShader construction outside of this class,
although there are still access to sk_shader from non-raster code.

Unfortunately this looks like a lot to transport, but I guess we'll have to do
it.

[enne (OOO), 2017-05-23 18:55:02]

https://codereview.chromium.org/2893083002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Gradient.cpp (right):

https://codereview.chromium.org/2893083002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Gradient.cpp:170:
flags.setShader(WTF::MakeUnique<PaintShader>(*cached_shader_));
This line is probably the one that's most concerning to me, largely because I'm
not sure I understand what this code will do in the future.  In the future there
won't be an underlying sk_shader and so every shader type will just construct a
copy of itself?

I guess I'm not sure I understand what the goal of caching these shaders will
be, other than avoiding SkShader creation.

https://codereview.chromium.org/2893083002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Pattern.cpp (right):

https://codereview.chromium.org/2893083002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Pattern.cpp:63: return local_matrix
!= cached_shader_->sk_shader()->getLocalMatrix();
All of these sk_shader calls seem easy to avoid by just storing the local matrix
locally.  That could be done in a followup though.

[vmpstr, 2017-05-31 20:22:55]

Description was changed from

==========
wip: PaintShader

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[vmpstr, 2017-05-31 20:24:57]

PTAL. I think we discussed moving a few more checks from Gradient.cpp, or at
least ensuring that we can know whether we can construct a shader or not.

I'm kind of on the fence with whether to keep this set of constructors, or write
static MakeBlahShader functions that return unique ptrs, which allows us the
possibility of returning nullptr. Let me know if you think that's a good idea.

[vmpstr, 2017-06-02 20:17:22]

PTAL. I've moved the fallback color to paint shader here. For now, it still
relies on trying to build the skshader internally if that fails, it uses the
fallback color, but this can change in the future to do the actual checks that
would cause it to fail in the ctors. Or even deferring that decision until
raster.

[enne (OOO), 2017-06-02 20:23:45]

lgtm

[vmpstr, 2017-06-02 20:28:03]

vmpstr@chromium.org changed reviewers:
+ pdr@chromium.org, piman@chromium.org, sky@chromium.org

[vmpstr, 2017-06-02 20:28:04]

+pdr for blink
+sky for chrome/ and ui/
+piman for content/

Please take a look.

[piman, 2017-06-02 20:43:36]

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_flags.h
File cc/paint/paint_flags.h (right):

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_flags.h#...
cc/paint/paint_flags.h:175: ALWAYS_INLINE void
setShader(std::unique_ptr<PaintShader> shader) {
Why are we taking a unique_ptr<PaintShader> if PaintShader just wraps a sk_sp
and therefore is cheap to move (or even copy)? Adding a level of memory
allocation + indirection seems like pure overhead.

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_shader.h
File cc/paint/paint_shader.h (right):

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_shader.h...
cc/paint/paint_shader.h:30: SkColor fallback_color = SK_ColorTRANSPARENT);
At the call site, determining what kind of shader is created is very
non-obvious, since it's based on the exact number and type of the parameters
(doubly hard with the default values), which don't even necessarily have names.

Would you consider instead having factory functions, e.g.:
static PaintShader MakeLinearGradient(const SkPoint points[], const SkColor
colors[], const SkScalar pos[], int count, SkShader::TileMode mode, uint32_t
flags = 0, const SkMatrix* local_matrix = nullptr, SkColor fallback_color =
SK_ColorTRANSPARENT); and so on?

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_shader.h...
cc/paint/paint_shader.h:75: PaintShader(PaintShader&& other);
nit: should we also have copy-assign and move-assign operators (rule-of-five)?

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_shader.h...
cc/paint/paint_shader.h:81: explicit PaintShader(sk_sp<SkShader> shader, SkColor
fallback_color);
nit: no need for explicit

[vmpstr, 2017-06-02 20:48:37]

Description was changed from

==========
cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

BUG=728359
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[vmpstr, 2017-06-02 20:52:00]

(just comments; will upload a new patch set)

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_flags.h
File cc/paint/paint_flags.h (right):

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_flags.h#...
cc/paint/paint_flags.h:175: ALWAYS_INLINE void
setShader(std::unique_ptr<PaintShader> shader) {
On 2017/06/02 20:43:36, piman wrote:
> Why are we taking a unique_ptr<PaintShader> if PaintShader just wraps a sk_sp
> and therefore is cheap to move (or even copy)? Adding a level of memory
> allocation + indirection seems like pure overhead.

This is a staging step. I've added a BUG= reference for the full plan.
Eventually, we won't be constructing the skshader until raster time, which means
all of the different ctor parameters that we store are going to be a part of
PaintShader (ie it won't be cheap to copy/move).

For this patch, we're just moving any SkShader construction for purposes of
paint out of the codebase and instead relying on PaintShader for doing this
work.

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_shader.h
File cc/paint/paint_shader.h (right):

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_shader.h...
cc/paint/paint_shader.h:30: SkColor fallback_color = SK_ColorTRANSPARENT);
On 2017/06/02 20:43:36, piman wrote:
> At the call site, determining what kind of shader is created is very
> non-obvious, since it's based on the exact number and type of the parameters
> (doubly hard with the default values), which don't even necessarily have
names.
> 
> Would you consider instead having factory functions, e.g.:
> static PaintShader MakeLinearGradient(const SkPoint points[], const SkColor
> colors[], const SkScalar pos[], int count, SkShader::TileMode mode, uint32_t
> flags = 0, const SkMatrix* local_matrix = nullptr, SkColor fallback_color =
> SK_ColorTRANSPARENT); and so on?

Yes, I'll do that. Thanks!

[pdr., 2017-06-02 21:08:19]

third_party/WebKit LGTM

[pdr., 2017-06-02 21:08:19]

third_party/WebKit LGTM

[pdr., 2017-06-02 21:09:15]

On 2017/06/02 at 21:08:19, pdr. wrote:
> third_party/WebKit LGTM

Oops, let me take this one back. My first LGTM still stands tho.

[sky, 2017-06-02 22:38:53]

On 2017/06/02 21:09:15, pdr. wrote:
> On 2017/06/02 at 21:08:19, pdr. wrote:
> > third_party/WebKit LGTM
> 
> Oops, let me take this one back. My first LGTM still stands tho.

Are you sure it wasn't the middle one? (I'm joking! couldn't resist, sorry).

[sky, 2017-06-02 22:51:05]

LGTM

https://codereview.chromium.org/2893083002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/2893083002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.cc:121:
flags.setShader(base::MakeUnique<cc::PaintShader>(
include base/memory/ptr_util.h?

https://codereview.chromium.org/2893083002/diff/60001/ui/gfx/skia_paint_util.h
File ui/gfx/skia_paint_util.h (right):

https://codereview.chromium.org/2893083002/diff/60001/ui/gfx/skia_paint_util....
ui/gfx/skia_paint_util.h:28: GFX_EXPORT std::unique_ptr<cc::PaintShader>
CreateImageRepShader(
Include <memory>?

[vmpstr, 2017-06-05 21:02:07]

PTAL

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_shader.h
File cc/paint/paint_shader.h (right):

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_shader.h...
cc/paint/paint_shader.h:30: SkColor fallback_color = SK_ColorTRANSPARENT);
On 2017/06/02 20:52:00, vmpstr wrote:
> On 2017/06/02 20:43:36, piman wrote:
> > At the call site, determining what kind of shader is created is very
> > non-obvious, since it's based on the exact number and type of the parameters
> > (doubly hard with the default values), which don't even necessarily have
> names.
> > 
> > Would you consider instead having factory functions, e.g.:
> > static PaintShader MakeLinearGradient(const SkPoint points[], const SkColor
> > colors[], const SkScalar pos[], int count, SkShader::TileMode mode, uint32_t
> > flags = 0, const SkMatrix* local_matrix = nullptr, SkColor fallback_color =
> > SK_ColorTRANSPARENT); and so on?
> 
> Yes, I'll do that. Thanks!

Done.

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_shader.h...
cc/paint/paint_shader.h:75: PaintShader(PaintShader&& other);
On 2017/06/02 20:43:36, piman wrote:
> nit: should we also have copy-assign and move-assign operators (rule-of-five)?

Done.

https://codereview.chromium.org/2893083002/diff/60001/cc/paint/paint_shader.h...
cc/paint/paint_shader.h:81: explicit PaintShader(sk_sp<SkShader> shader, SkColor
fallback_color);
On 2017/06/02 20:43:36, piman wrote:
> nit: no need for explicit

Done.

https://codereview.chromium.org/2893083002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/2893083002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/tab.cc:121:
flags.setShader(base::MakeUnique<cc::PaintShader>(
On 2017/06/02 22:51:05, sky wrote:
> include base/memory/ptr_util.h?

Not needed after changes piman@ requested.

https://codereview.chromium.org/2893083002/diff/60001/ui/gfx/skia_paint_util.h
File ui/gfx/skia_paint_util.h (right):

https://codereview.chromium.org/2893083002/diff/60001/ui/gfx/skia_paint_util....
ui/gfx/skia_paint_util.h:28: GFX_EXPORT std::unique_ptr<cc::PaintShader>
CreateImageRepShader(
On 2017/06/02 22:51:05, sky wrote:
> Include <memory>?

Done.

[vmpstr, 2017-06-05 21:03:01]

vmpstr@chromium.org changed reviewers:
+ junov@chromium.org

[vmpstr, 2017-06-05 21:03:02]

+junov for third_party/WebKit/Source/modules/canvas2d/ as well. Please take a
look.

[piman, 2017-06-05 21:07:29]

lgtm

[vmpstr, 2017-06-06 20:04:20]

ping junov, could you please take a look?

[vmpstr, 2017-06-07 17:07:13]

vmpstr@chromium.org changed reviewers:
+ senorblanco@chromium.org

[vmpstr, 2017-06-07 17:07:14]

+senorblanco for 
third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp as well.
Please take a look.

[Stephen White, 2017-06-07 17:23:22]

On 2017/06/07 17:07:14, vmpstr wrote:
> +senorblanco for 
> third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp as well.
> Please take a look.

Looks good, but I've pinged Justin to be sure.

[Justin Novosad, 2017-06-07 17:24:12]

lgtm

[vmpstr, 2017-06-07 17:25:25]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-06-07 17:25:26]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
enne@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2893083002/#ps80001
(title: "update")

[commit-bot: I haz the power, 2017-06-07 17:25:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 17:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 17:37:55]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[vmpstr, 2017-06-07 18:14:13]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 18:14:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 18:31:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 18:31:40]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2017-06-07 18:50:47]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 18:51:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 19:07:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 19:07:18]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[vmpstr, 2017-06-07 21:32:41]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 21:33:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 22:16:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 22:16:57]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[vmpstr, 2017-06-07 23:11:40]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-06-07 23:11:41]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
junov@chromium.org, enne@chromium.org, pdr@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2893083002/#ps140001
(title: "fallback")

[commit-bot: I haz the power, 2017-06-07 23:12:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 23:54:08]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1496877100564900,
"parent_rev": "46ab10923ea52c1e02980027a5e098ae25e904b7", "commit_rev":
"cda52d0cc0fea52b996fce1663a8de5141fe48c3"}

[commit-bot: I haz the power, 2017-06-07 23:54:20]

Description was changed from

==========
cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

BUG=728359
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

BUG=728359
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2893083002
Cr-Commit-Position: refs/heads/master@{#477810}
Committed:
https://chromium.googlesource.com/chromium/src/+/cda52d0cc0fea52b996fce1663a8...
==========

[commit-bot: I haz the power, 2017-06-07 23:54:21]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/cda52d0cc0fea52b996fce1663a8...

[Sam McNally, 2017-06-08 00:29:48]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2928703005/ by sammc@chromium.org.

The reason for reverting is: Broke Linux ChromiumOS Builder (dbg):
https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS....

[findit-for-me, 2017-06-08 00:42:51]

Findit (https://goo.gl/kROfz5) confirmed this CL at revision 477810 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[vmpstr, 2017-06-08 18:19:10]

Description was changed from

==========
cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

BUG=728359
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2893083002
Cr-Commit-Position: refs/heads/master@{#477810}
Committed:
https://chromium.googlesource.com/chromium/src/+/cda52d0cc0fea52b996fce1663a8...
==========

to

==========
cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

BUG=728359
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2893083002
Cr-Commit-Position: refs/heads/master@{#477810}
Committed:
https://chromium.googlesource.com/chromium/src/+/cda52d0cc0fea52b996fce1663a8...
==========

[vmpstr, 2017-06-08 18:20:08]

I had to add //cc/paint to ash/touch_hud/BUILD.gn. sky@ do you mind taking
another look at ash/?

[vmpstr, 2017-06-08 18:52:36]

The CQ bit was checked by vmpstr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 18:53:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-06-08 21:22:17]

ash LGTM

[vmpstr, 2017-06-08 21:23:38]

The CQ bit was unchecked by vmpstr@chromium.org

[vmpstr, 2017-06-08 21:23:43]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-06-08 21:23:43]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org,
enne@chromium.org, pdr@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2893083002/#ps160001
(title: "update")

[commit-bot: I haz the power, 2017-06-08 21:24:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 21:39:47]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1496957023387940,
"parent_rev": "e3338722a11a1b0cac7b4a189532bbf52b34193c", "commit_rev":
"6d6e355ddf6a90640308b2fc67ad65a7a2ff1f86"}

[commit-bot: I haz the power, 2017-06-08 21:40:00]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1496957023387940,
"parent_rev": "f7931a198eca2827ceb8e52d103bba250e39aae3", "commit_rev":
"7b99c95846da32cdb1060f59a1a1f5bd27ab2696"}

[commit-bot: I haz the power, 2017-06-08 21:40:17]

Description was changed from

==========
cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

BUG=728359
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2893083002
Cr-Commit-Position: refs/heads/master@{#477810}
Committed:
https://chromium.googlesource.com/chromium/src/+/cda52d0cc0fea52b996fce1663a8...
==========

to

==========
cc: Move SkShader construction to a single spot in PaintShader

This patch moves SkShader construction to be only in PaintShader
(for the purposes of paint, at least). This ensures that we can
transport all of the relevant parameters required for the shader
and defer construction until raster.

BUG=728359
R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2893083002
Cr-Original-Commit-Position: refs/heads/master@{#477810}
Committed:
https://chromium.googlesource.com/chromium/src/+/cda52d0cc0fea52b996fce1663a8...
Review-Url: https://codereview.chromium.org/2893083002
Cr-Commit-Position: refs/heads/master@{#478095}
Committed:
https://chromium.googlesource.com/chromium/src/+/7b99c95846da32cdb1060f59a1a1...
==========

[commit-bot: I haz the power, 2017-06-08 21:40:20]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/7b99c95846da32cdb1060f59a1a1...