Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2928703005: Revert of cc: Move SkShader construction to a single spot in PaintShader (Closed)

Created:
3 years, 6 months ago by Sam McNally
Modified:
3 years, 6 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, fs, gyuyoung2, haraken, jam, kinuko+watch, kouhei+svg_chromium.org, miu+watch_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Move SkShader construction to a single spot in PaintShader (patchset #8 id:140001 of https://codereview.chromium.org/2893083002/ ) Reason for revert: Broke Linux ChromiumOS Builder (dbg): https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Builder%20%28dbg%29/88131 Original issue's description: > cc: Move SkShader construction to a single spot in PaintShader > > This patch moves SkShader construction to be only in PaintShader > (for the purposes of paint, at least). This ensures that we can > transport all of the relevant parameters required for the shader > and defer construction until raster. > > BUG=728359 > R=enne@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2893083002 > Cr-Commit-Position: refs/heads/master@{#477810} > Committed: https://chromium.googlesource.com/chromium/src/+/cda52d0cc0fea52b996fce1663a8de5141fe48c3 TBR=enne@chromium.org,pdr@chromium.org,sky@chromium.org,piman@chromium.org,junov@chromium.org,senorblanco@chromium.org,vmpstr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=728359 Review-Url: https://codereview.chromium.org/2928703005 Cr-Commit-Position: refs/heads/master@{#477827} Committed: https://chromium.googlesource.com/chromium/src/+/8cae4d389092473a097baf547b1fecfe2259e748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -372 lines) Patch
M ash/touch_hud/touch_hud_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/paint/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M cc/paint/discardable_image_map_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/paint/discardable_image_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/paint/paint_flags.h View 3 chunks +5 lines, -16 lines 0 comments Download
M cc/paint/paint_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/paint/paint_op_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/paint/paint_op_buffer_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/paint/paint_shader.h View 1 chunk +17 lines, -77 lines 0 comments Download
D cc/paint/paint_shader.cc View 1 chunk +0 lines, -115 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/aura/shadow_layer_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Gradient.h View 2 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Gradient.cpp View 7 chunks +35 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 4 chunks +14 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImagePattern.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImagePattern.cpp View 2 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/PaintRecordPattern.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/PaintRecordPattern.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Pattern.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Pattern.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintShader.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/render_text.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/gfx/render_text.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M ui/gfx/skia_paint_util.h View 2 chunks +8 lines, -10 lines 0 comments Download
M ui/gfx/skia_paint_util.cc View 3 chunks +15 lines, -18 lines 0 comments Download
M ui/native_theme/native_theme_base.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/cocoa_scroll_bar.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Sam McNally
Created Revert of cc: Move SkShader construction to a single spot in PaintShader
3 years, 6 months ago (2017-06-08 00:29:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2928703005/1
3 years, 6 months ago (2017-06-08 00:30:13 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 00:31:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8cae4d389092473a097baf547b1f...

Powered by Google App Engine
This is Rietveld 408576698