Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/Pattern.cpp

Issue 2893083002: cc: Move SkShader construction to a single spot in PaintShader (Closed)
Patch Set: update Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008 Apple Computer, Inc. All rights reserved.
3 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 3 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
4 * Copyright (C) 2013 Google, Inc. All rights reserved. 4 * Copyright (C) 2013 Google, Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 52
53 Pattern::Pattern(RepeatMode repeat_mode) : repeat_mode_(repeat_mode) {} 53 Pattern::Pattern(RepeatMode repeat_mode) : repeat_mode_(repeat_mode) {}
54 54
55 Pattern::~Pattern() { 55 Pattern::~Pattern() {
56 } 56 }
57 57
58 void Pattern::ApplyToFlags(PaintFlags& flags, const SkMatrix& local_matrix) { 58 void Pattern::ApplyToFlags(PaintFlags& flags, const SkMatrix& local_matrix) {
59 if (!cached_shader_ || IsLocalMatrixChanged(local_matrix)) 59 if (!cached_shader_ || IsLocalMatrixChanged(local_matrix))
60 cached_shader_ = CreateShader(local_matrix); 60 cached_shader_ = CreateShader(local_matrix);
61 61
62 flags.setShader(cached_shader_); 62 flags.setShader(WTF::MakeUnique<PaintShader>(*cached_shader_));
63 } 63 }
64 64
65 bool Pattern::IsLocalMatrixChanged(const SkMatrix& local_matrix) const { 65 bool Pattern::IsLocalMatrixChanged(const SkMatrix& local_matrix) const {
66 return local_matrix != cached_shader_->getLocalMatrix(); 66 return local_matrix != cached_shader_->sk_shader()->getLocalMatrix();
67 } 67 }
68 68
69 } // namespace blink 69 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/Pattern.h ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintShader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698