Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)

Created:
3 years, 8 months ago by Mark Mentovai
Modified:
3 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, net-reviews_chromium.org, extensions-reviews_chromium.org, mac-reviews_chromium.org, jperaza, Sigurður Ásgeirsson
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 9104d53d1c60 Fix thread startup in snapshot reader test 542a91e20e39 Fix the race causing flaky CrashpadClient tests 270490ff79df win: Be more careful about child process exit codes 6c8a3f700738 win: Use a semaphore for synchronization in ProcessSnapshotTest f14eda221fe7 win: Be more careful about exit codes in end_to_end_test.py 449dfc4b5dc1 Remove BUG_LINE_FORMAT from codereview.settings d6837b2b869f mac: Fix SystemSnapshotMacTest.TimeZone on macOS 10.12.4 96dc950eaf26 posix: Add ScopedMmap for managing memory-mapped regions 3127026a95c1 Convert generate_doxygen.sh to generate_doxygen.py 1a6ae8ce0ba8 posix: Don’t accumulate zombies in ProcessInfo.Forked test aa2bc55777b9 posix: Allow ScopedMmap::ResetAddrLen() to deal with overlap 385fe6615f11 posix: DCHECK for (addr + len) overflow in ScopedMmap::ResetAddrLen() c39e4dc9769e mac: Remove obsolete comment about mach_msg_header_t::msgh_reserved 46883516231e “Promote” test::Paths::Executable() to Paths::Executable() fa8ef92dc7f1 linux: Add ProcessMemory which reads another process' memory 4b450c813795 test: Use (actual, [un]expected) in gtest {ASSERT,EXPECT}_{EQ,NE} 76a67a37b1d0 Add the --monitor-self argument to crashpad_handler 45305395ad87 win: Determine length of unloaded module names 8f07f7481ab4 handler: Add --monitor-self-annotations b4095401639e handler: Reuse existing annotations SimpleStringDictionary BUG=crashpad:30, crashpad:143 Review-Url: https://codereview.chromium.org/2804713002 Cr-Commit-Position: refs/heads/master@{#462093} Committed: https://chromium.googlesource.com/chromium/src/+/a4d005995302373474923a31d642c8f49071a0ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5495 lines, -4131 lines) Patch
M build/secondary/third_party/crashpad/crashpad/util/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/crashpad/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/capture_context_mac_test.cc View 3 chunks +16 lines, -16 lines 0 comments Download
M third_party/crashpad/crashpad/client/client_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/crashpad/crashpad/client/crash_report_database_test.cc View 19 chunks +200 lines, -200 lines 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_client_win_test.cc View 6 chunks +200 lines, -12 lines 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_info.h View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/client/prune_crash_reports_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/client/settings_test.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M third_party/crashpad/crashpad/client/simple_address_range_bag_test.cc View 4 chunks +17 lines, -17 lines 0 comments Download
M third_party/crashpad/crashpad/client/simple_string_dictionary_test.cc View 13 chunks +37 lines, -36 lines 0 comments Download
M third_party/crashpad/crashpad/client/simulate_crash_mac_test.cc View 7 chunks +36 lines, -36 lines 0 comments Download
M third_party/crashpad/crashpad/doc/developing.md View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/doc/support/generate.sh View 1 chunk +1 line, -1 line 0 comments Download
A third_party/crashpad/crashpad/doc/support/generate_doxygen.py View 1 chunk +49 lines, -0 lines 0 comments Download
D third_party/crashpad/crashpad/doc/support/generate_doxygen.sh View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/crashpad/crashpad/handler/crashpad_handler.md View 1 chunk +45 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/handler_main.cc View 19 chunks +213 lines, -61 lines 0 comments Download
M third_party/crashpad/crashpad/handler/win/crash_other_program.cc View 7 chunks +34 lines, -15 lines 0 comments Download
M third_party/crashpad/crashpad/handler/win/crashy_test_z7_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_context_writer_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_crashpad_info_writer_test.cc View 6 chunks +41 lines, -41 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_exception_writer_test.cc View 2 chunks +18 lines, -18 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_file_writer_test.cc View 15 chunks +57 lines, -57 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_handle_writer_test.cc View 4 chunks +44 lines, -44 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_info_writer_test.cc View 3 chunks +19 lines, -19 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_writer_test.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_misc_info_writer_test.cc View 9 chunks +39 lines, -39 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_crashpad_info_writer_test.cc View 12 chunks +96 lines, -96 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_module_writer_test.cc View 14 chunks +67 lines, -67 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_rva_list_writer_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer_test.cc View 8 chunks +87 lines, -86 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_string_writer_test.cc View 7 chunks +25 lines, -26 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_system_info_writer_test.cc View 9 chunks +106 lines, -106 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_thread_id_map_test.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_thread_writer_test.cc View 8 chunks +45 lines, -44 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_unloaded_module_writer_test.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_user_stream_writer_test.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_writable_test.cc View 35 chunks +103 lines, -102 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_context_test_util.cc View 3 chunks +135 lines, -133 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_file_writer_test_util.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_memory_writer_test_util.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_rva_list_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_string_writer_test_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_writable_test_util.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/api/module_annotations_win_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/cpu_context_test.cc View 8 chunks +54 lines, -54 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/crashpad_info_client_options_test.cc View 12 chunks +45 lines, -45 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/cpu_context_mac_test.cc View 18 chunks +54 lines, -54 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc View 8 chunks +19 lines, -18 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader_test.cc View 19 chunks +70 lines, -69 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/mach_o_image_segment_reader_test.cc View 5 chunks +35 lines, -35 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc View 20 chunks +51 lines, -52 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/process_types_test.cc View 11 chunks +89 lines, -88 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/mac/system_snapshot_mac_test.cc View 9 chunks +32 lines, -25 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump_test.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/cpu_context_win_test.cc View 3 chunks +22 lines, -22 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/crashpad_snapshot_test_image_reader.cc View 4 chunks +15 lines, -14 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/end_to_end_test.py View 4 chunks +37 lines, -18 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc View 10 chunks +24 lines, -11 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/extra_memory_ranges_test.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/pe_image_annotations_reader_test.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/pe_image_reader_test.cc View 5 chunks +24 lines, -24 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_reader_win_test.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_snapshot_win_test.cc View 3 chunks +59 lines, -54 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/system_snapshot_win_test.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/crashpad/crashpad/test/errors.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/test/file.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/test/hex_string.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/test/hex_string_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/test/mac/mach_errors.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/test/mac/mach_multiprocess.cc View 6 chunks +32 lines, -31 lines 0 comments Download
M third_party/crashpad/crashpad/test/multiprocess_exec_posix.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/test/multiprocess_exec_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/test/multiprocess_exec_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/test/multiprocess_posix.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/test/multiprocess_posix_test.cc View 4 chunks +7 lines, -7 lines 0 comments Download
D third_party/crashpad/crashpad/test/paths.h View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/crashpad/crashpad/test/paths.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D third_party/crashpad/crashpad/test/paths_linux.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/crashpad/crashpad/test/paths_mac.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/crashpad/crashpad/test/paths_test.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/crashpad/crashpad/test/paths_test_data_root.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/crashpad/crashpad/test/paths_win.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/crashpad/crashpad/test/scoped_temp_dir_posix.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/test/scoped_temp_dir_test.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/crashpad/crashpad/test/scoped_temp_dir_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/test/test.gyp View 2 chunks +2 lines, -12 lines 0 comments Download
A + third_party/crashpad/crashpad/test/test_paths.h View 3 chunks +7 lines, -5 lines 0 comments Download
A + third_party/crashpad/crashpad/test/test_paths.cc View 4 chunks +29 lines, -19 lines 0 comments Download
A + third_party/crashpad/crashpad/test/test_paths_test.cc View 2 chunks +4 lines, -16 lines 0 comments Download
A + third_party/crashpad/crashpad/test/test_paths_test_data_root.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/test/test_test.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/test/win/child_launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/test/win/win_child_process.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/test/win/win_child_process_test.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/test/win/win_multiprocess.h View 3 chunks +26 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/test/win/win_multiprocess.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/third_party/getopt/README.crashpad View 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/third_party/getopt/getopt.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/third_party/getopt/getopt.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/util/file/delimited_file_reader_test.cc View 13 chunks +147 lines, -147 lines 0 comments Download
M third_party/crashpad/crashpad/util/file/file_io_test.cc View 8 chunks +30 lines, -30 lines 0 comments Download
M third_party/crashpad/crashpad/util/file/string_file_test.cc View 9 chunks +217 lines, -217 lines 0 comments Download
A + third_party/crashpad/crashpad/util/linux/address_types.h View 1 chunk +11 lines, -13 lines 0 comments Download
A third_party/crashpad/crashpad/util/linux/process_memory.h View 1 chunk +105 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/linux/process_memory.cc View 1 chunk +123 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/linux/process_memory_test.cc View 1 chunk +403 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/mac/checked_mach_address_range_test.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/util/mac/launchd_test.mm View 8 chunks +30 lines, -30 lines 0 comments Download
M third_party/crashpad/crashpad/util/mac/mac_util_test.mm View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/crashpad/crashpad/util/mac/service_management_test.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/util/mac/xattr_test.cc View 7 chunks +21 lines, -21 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/child_port_handshake_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/child_port_server_test.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/composite_mach_message_server_test.cc View 10 chunks +19 lines, -19 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/exc_client_variants_test.cc View 5 chunks +39 lines, -38 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/exc_server_variants_test.cc View 20 chunks +84 lines, -83 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/exception_behaviors_test.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/exception_ports_test.cc View 13 chunks +25 lines, -25 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/exception_types_test.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/mach_extensions_test.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/mach_message.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/mach_message_server_test.cc View 11 chunks +56 lines, -53 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/mach_message_test.cc View 8 chunks +45 lines, -45 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/notify_server_test.cc View 12 chunks +23 lines, -23 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/scoped_task_suspend_test.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/symbolic_constants_mach_test.cc View 3 chunks +15 lines, -15 lines 0 comments Download
M third_party/crashpad/crashpad/util/mach/task_memory_test.cc View 22 chunks +63 lines, -63 lines 0 comments Download
A + third_party/crashpad/crashpad/util/misc/paths.h View 1 chunk +18 lines, -12 lines 0 comments Download
A + third_party/crashpad/crashpad/util/misc/paths_linux.cc View 2 chunks +11 lines, -12 lines 0 comments Download
A + third_party/crashpad/crashpad/util/misc/paths_mac.cc View 2 chunks +12 lines, -7 lines 0 comments Download
A + third_party/crashpad/crashpad/util/misc/paths_test.cc View 1 chunk +7 lines, -15 lines 0 comments Download
A + third_party/crashpad/crashpad/util/misc/paths_win.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/util/misc/random_string_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/misc/uuid_test.cc View 6 chunks +60 lines, -60 lines 0 comments Download
M third_party/crashpad/crashpad/util/net/http_body_gzip_test.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/crashpad/crashpad/util/net/http_body_test.cc View 12 chunks +48 lines, -48 lines 0 comments Download
M third_party/crashpad/crashpad/util/net/http_multipart_builder_test.cc View 8 chunks +87 lines, -87 lines 0 comments Download
M third_party/crashpad/crashpad/util/net/http_transport_test.cc View 10 chunks +27 lines, -27 lines 0 comments Download
M third_party/crashpad/crashpad/util/numeric/checked_address_range_test.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/util/numeric/checked_range_test.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/util/numeric/in_range_cast_test.cc View 1 chunk +79 lines, -79 lines 0 comments Download
M third_party/crashpad/crashpad/util/numeric/int128_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/posix/process_info_test.cc View 8 chunks +48 lines, -34 lines 0 comments Download
A third_party/crashpad/crashpad/util/posix/scoped_mmap.h View 1 chunk +103 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/posix/scoped_mmap.cc View 1 chunk +115 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/posix/scoped_mmap_test.cc View 1 chunk +318 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/posix/signals_test.cc View 6 chunks +13 lines, -17 lines 0 comments Download
M third_party/crashpad/crashpad/util/posix/symbolic_constants_posix_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/aligned_allocator_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/map_insert_test.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/string_number_conversion_test.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/strlcpy_test.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/crashpad/crashpad/util/stdlib/strnlen_test.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/crashpad/crashpad/util/string/split_string_test.cc View 2 chunks +29 lines, -29 lines 0 comments Download
M third_party/crashpad/crashpad/util/synchronization/semaphore_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/util/thread/thread_log_messages_test.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M third_party/crashpad/crashpad/util/thread/worker_thread_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/util/util.gyp View 4 chunks +11 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/util_test.gyp View 4 chunks +10 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/capture_context_test.cc View 3 chunks +30 lines, -33 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/command_line_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/get_function_test.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/handle_test.cc View 1 chunk +18 lines, -18 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/initial_client_data_test.cc View 1 chunk +15 lines, -16 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/process_info_test.cc View 20 chunks +95 lines, -95 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/registration_protocol_win_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/scoped_process_suspend_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Mark Mentovai
3 years, 8 months ago (2017-04-05 14:17:46 UTC) #4
scottmg
I suppose we have to swap all the EXPECT_EQ back to (expected, actual) until we ...
3 years, 8 months ago (2017-04-05 15:08:54 UTC) #5
Mark Mentovai
Ha! https://groups.google.com/a/chromium.org/d/topic/chromium-dev/XOTHccL5tHM is promising, at least.
3 years, 8 months ago (2017-04-05 15:10:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804713002/1
3 years, 8 months ago (2017-04-05 15:11:38 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 16:10:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a4d005995302373474923a31d642...

Powered by Google App Engine
This is Rietveld 408576698