Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: third_party/crashpad/crashpad/minidump/test/minidump_string_writer_test_util.cc

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/minidump/test/minidump_string_writer_test_util.cc
diff --git a/third_party/crashpad/crashpad/minidump/test/minidump_string_writer_test_util.cc b/third_party/crashpad/crashpad/minidump/test/minidump_string_writer_test_util.cc
index d5c735434d3b4e82c2f2e4c4471d5f91910879d6..2c07934f5fe366240259d977aee82c4b7d1dc600 100644
--- a/third_party/crashpad/crashpad/minidump/test/minidump_string_writer_test_util.cc
+++ b/third_party/crashpad/crashpad/minidump/test/minidump_string_writer_test_util.cc
@@ -36,7 +36,7 @@ const T* TMinidumpStringAtRVA(const std::string& file_contents, RVA rva) {
// units.
const size_t kCodeUnitSize = sizeof(string_base->Buffer[0]);
if (string_base->Length % kCodeUnitSize != 0) {
- EXPECT_EQ(0u, string_base->Length % kCodeUnitSize);
+ EXPECT_EQ(string_base->Length % kCodeUnitSize, 0u);
return nullptr;
}
@@ -51,11 +51,11 @@ const T* TMinidumpStringAtRVA(const std::string& file_contents, RVA rva) {
return nullptr;
}
- EXPECT_EQ(string_base, string);
+ EXPECT_EQ(string, string_base);
// Require the NUL terminator to be NUL.
if (string->Buffer[string->Length / kCodeUnitSize] != '\0') {
- EXPECT_EQ('\0', string->Buffer[string->Length / kCodeUnitSize]);
+ EXPECT_EQ(string->Buffer[string->Length / kCodeUnitSize], '\0');
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698