Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: third_party/crashpad/crashpad/util/mach/child_port_server_test.cc

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/mach/child_port_server_test.cc
diff --git a/third_party/crashpad/crashpad/util/mach/child_port_server_test.cc b/third_party/crashpad/crashpad/util/mach/child_port_server_test.cc
index 7a8dbf7733af7b1575e9f1100b947caef1a2f80f..d579ce914a9cbe251c61593d251ffc62ce51375e 100644
--- a/third_party/crashpad/crashpad/util/mach/child_port_server_test.cc
+++ b/third_party/crashpad/crashpad/util/mach/child_port_server_test.cc
@@ -76,14 +76,14 @@ struct MIGReply : public mig_reply_error_t {
}
void Verify() {
- EXPECT_EQ(implicit_cast<mach_msg_bits_t>(MACH_MSGH_BITS(0, 0)),
- Head.msgh_bits);
- EXPECT_EQ(sizeof(*this), Head.msgh_size);
- EXPECT_EQ(kMachPortNull, Head.msgh_remote_port);
- EXPECT_EQ(kMachPortNull, Head.msgh_local_port);
- EXPECT_EQ(10111, Head.msgh_id);
- EXPECT_EQ(0, memcmp(&NDR, &NDR_record, sizeof(NDR)));
- EXPECT_EQ(MIG_NO_REPLY, RetCode);
+ EXPECT_EQ(Head.msgh_bits,
+ implicit_cast<mach_msg_bits_t>(MACH_MSGH_BITS(0, 0)));
+ EXPECT_EQ(Head.msgh_size, sizeof(*this));
+ EXPECT_EQ(Head.msgh_remote_port, kMachPortNull);
+ EXPECT_EQ(Head.msgh_local_port, kMachPortNull);
+ EXPECT_EQ(Head.msgh_id, 10111);
+ EXPECT_EQ(memcmp(&NDR, &NDR_record, sizeof(NDR)), 0);
+ EXPECT_EQ(RetCode, MIG_NO_REPLY);
}
};
@@ -104,13 +104,13 @@ TEST(ChildPortServer, MockChildPortCheckIn) {
std::set<mach_msg_id_t> expect_request_ids;
expect_request_ids.insert(10011); // There is no constant for this.
- EXPECT_EQ(expect_request_ids, server.MachMessageServerRequestIDs());
+ EXPECT_EQ(server.MachMessageServerRequestIDs(), expect_request_ids);
ChildPortCheckInRequest request;
- EXPECT_EQ(request.Head.msgh_size, server.MachMessageServerRequestSize());
+ EXPECT_EQ(server.MachMessageServerRequestSize(), request.Head.msgh_size);
MIGReply reply;
- EXPECT_EQ(sizeof(reply), server.MachMessageServerReplySize());
+ EXPECT_EQ(server.MachMessageServerReplySize(), sizeof(reply));
EXPECT_CALL(server_interface,
HandleChildPortCheckIn(kServerLocalPort,

Powered by Google App Engine
This is Rietveld 408576698