Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: third_party/crashpad/crashpad/util/mac/service_management_test.mm

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/mac/service_management_test.mm
diff --git a/third_party/crashpad/crashpad/util/mac/service_management_test.mm b/third_party/crashpad/crashpad/util/mac/service_management_test.mm
index cdfd082356a2ebb837b8cc367c5e7a553422f07c..769c32f1b042f12a507f04e6f8d7400c5ab94b87 100644
--- a/third_party/crashpad/crashpad/util/mac/service_management_test.mm
+++ b/third_party/crashpad/crashpad/util/mac/service_management_test.mm
@@ -72,7 +72,7 @@ void ExpectProcessIsRunning(pid_t pid, std::string& last_arg) {
}
ASSERT_FALSE(job_argv.empty());
- EXPECT_EQ(last_arg, job_argv.back());
+ EXPECT_EQ(job_argv.back(), last_arg);
}
// Ensures that the process with the specified PID is not running. Because the
@@ -103,7 +103,7 @@ void ExpectProcessIsNotRunning(pid_t pid, std::string& last_arg) {
}
ASSERT_FALSE(job_argv.empty());
- EXPECT_NE(last_arg, job_argv.back());
+ EXPECT_NE(job_argv.back(), last_arg);
}
TEST(ServiceManagement, SubmitRemoveJob) {
@@ -145,7 +145,7 @@ void ExpectProcessIsNotRunning(pid_t pid, std::string& last_arg) {
// Remove the job.
ASSERT_TRUE(ServiceManagementRemoveJob(kJobLabel, true));
EXPECT_FALSE(ServiceManagementIsJobLoaded(kJobLabel));
- EXPECT_EQ(0, ServiceManagementIsJobRunning(kJobLabel));
+ EXPECT_EQ(ServiceManagementIsJobRunning(kJobLabel), 0);
// Now that the job is unloaded, a subsequent attempt to unload it should be
// an error.
« no previous file with comments | « third_party/crashpad/crashpad/util/mac/mac_util_test.mm ('k') | third_party/crashpad/crashpad/util/mac/xattr_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698