Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8

third_party/crashpad/crashpad/test/multiprocess_posix_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 22 matching lines @@
 
   ~TestMultiprocess() {}
 
  private:
   // Multiprocess:
 
   void MultiprocessParent() override {
     FileHandle read_handle = ReadPipeHandle();
     char c;
     CheckedReadFileExactly(read_handle, &c, 1);
-    EXPECT_EQ('M', c);
+    EXPECT_EQ(c, 'M');
 
     pid_t pid;
     CheckedReadFileExactly(read_handle, &pid, sizeof(pid));
-    EXPECT_EQ(pid, ChildPID());
+    EXPECT_EQ(ChildPID(), pid);
 
     c = 'm';
     CheckedWriteFile(WritePipeHandle(), &c, 1);
 
     // The child will close its end of the pipe and exit. Make sure that the
     // parent sees EOF.
     CheckedReadFileAtEOF(read_handle);
   }
 
   void MultiprocessChild() override {
     FileHandle write_handle = WritePipeHandle();
 
     char c = 'M';
     CheckedWriteFile(write_handle, &c, 1);
 
     pid_t pid = getpid();
     CheckedWriteFile(write_handle, &pid, sizeof(pid));
 
     CheckedReadFileExactly(ReadPipeHandle(), &c, 1);
-    EXPECT_EQ('m', c);
+    EXPECT_EQ(c, 'm');
   }
 
   DISALLOW_COPY_AND_ASSIGN(TestMultiprocess);
 };
 
 TEST(Multiprocess, Multiprocess) {
   TestMultiprocess multiprocess;
   multiprocess.Run();
 }
 
@@ skipping 76 matching lines @@
   TestMultiprocessClosePipe(WhoCloses who_closes, WhatCloses what_closes)
       : Multiprocess(),
         who_closes_(who_closes),
         what_closes_(what_closes) {
   }
 
   ~TestMultiprocessClosePipe() {}
 
  private:
   void VerifyInitial() {
-    ASSERT_NE(-1, ReadPipeHandle());
-    ASSERT_NE(-1, WritePipeHandle());
+    ASSERT_NE(ReadPipeHandle(), -1);
+    ASSERT_NE(WritePipeHandle(), -1);
   }
 
   // Verifies that the partner process did what it was supposed to do. This must
   // only be called when who_closes_ names the partner process, not this
   // process.
   //
   // If the partner was supposed to close its write pipe, the read pipe will be
   // checked to ensure that it shows end-of-file.
   //
   // If the partner was supposed to close its read pipe, the write pipe will be
@@ skipping 15 matching lines @@
       // be terminated. Because the actual termination mechanism is not known,
       // no regex can be specified.
       EXPECT_DEATH_CHECK(CheckedWriteFile(WritePipeHandle(), &c, 1), "");
     }
   }
 
   void Close() {
     switch (what_closes_) {
       case kReadCloses:
         CloseReadPipe();
-        EXPECT_NE(-1, WritePipeHandle());
+        EXPECT_NE(WritePipeHandle(), -1);
         EXPECT_DEATH_CHECK(ReadPipeHandle(), "fd");
         break;
       case kWriteCloses:
         CloseWritePipe();
-        EXPECT_NE(-1, ReadPipeHandle());
+        EXPECT_NE(ReadPipeHandle(), -1);
         EXPECT_DEATH_CHECK(WritePipeHandle(), "fd");
         break;
       case kReadAndWriteClose:
         CloseReadPipe();
         CloseWritePipe();
         EXPECT_DEATH_CHECK(ReadPipeHandle(), "fd");
         EXPECT_DEATH_CHECK(WritePipeHandle(), "fd");
         break;
     }
   }
@@ skipping 64 matching lines @@
 TEST(MultiprocessDeathTest, ChildClosesReadAndWritePipe) {
   TestMultiprocessClosePipe multiprocess(
       TestMultiprocessClosePipe::kChildCloses,
       TestMultiprocessClosePipe::kReadAndWriteClose);
   multiprocess.Run();
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad