Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/crashpad/crashpad/util/numeric/checked_address_range_test.cc

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/numeric/checked_address_range_test.cc
diff --git a/third_party/crashpad/crashpad/util/numeric/checked_address_range_test.cc b/third_party/crashpad/crashpad/util/numeric/checked_address_range_test.cc
index 403c000f83f48dce2b8f631d68804df4afcd9d00..fa7ae87d2cfd07c99caabb962bc15a43f35cc448 100644
--- a/third_party/crashpad/crashpad/util/numeric/checked_address_range_test.cc
+++ b/third_party/crashpad/crashpad/util/numeric/checked_address_range_test.cc
@@ -128,10 +128,10 @@ TEST(CheckedAddressRange, IsValid) {
testcase.size));
CheckedAddressRange range_32(false, testcase.base, testcase.size);
- EXPECT_EQ(ExpectationForValidity32(testcase.validity), range_32.IsValid());
+ EXPECT_EQ(range_32.IsValid(), ExpectationForValidity32(testcase.validity));
CheckedAddressRange range_64(true, testcase.base, testcase.size);
- EXPECT_EQ(ExpectationForValidity64(testcase.validity), range_64.IsValid());
+ EXPECT_EQ(range_64.IsValid(), ExpectationForValidity64(testcase.validity));
}
}
@@ -175,8 +175,8 @@ TEST(CheckedAddressRange, ContainsValue) {
SCOPED_TRACE(base::StringPrintf(
"index %" PRIuS ", value 0x%" PRIx64, index, testcase.value));
- EXPECT_EQ(testcase.expectation,
- parent_range_32.ContainsValue(testcase.value));
+ EXPECT_EQ(parent_range_32.ContainsValue(testcase.value),
+ testcase.expectation);
}
CheckedAddressRange parent_range_64(true, 0x100000000, 0x1000);
@@ -237,8 +237,8 @@ TEST(CheckedAddressRange, ContainsRange) {
CheckedAddressRange child_range_32(false, testcase.base, testcase.size);
ASSERT_TRUE(child_range_32.IsValid());
- EXPECT_EQ(testcase.expectation,
- parent_range_32.ContainsRange(child_range_32));
+ EXPECT_EQ(parent_range_32.ContainsRange(child_range_32),
+ testcase.expectation);
}
CheckedAddressRange parent_range_64(true, 0x100000000, 0x1000);

Powered by Google App Engine
This is Rietveld 408576698