third_party/crashpad/crashpad/util/mach/child_port_handshake_test.cc - Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/util/mach/child_port_handshake_test.cc

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/util/mac/xattr_test.cc ('k') | third_party/crashpad/crashpad/util/mach/child_port_server_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/util/mach/child_port_handshake_test.cc

diff --git a/third_party/crashpad/crashpad/util/mach/child_port_handshake_test.cc b/third_party/crashpad/crashpad/util/mach/child_port_handshake_test.cc

index f77107b53982614c66074238711cb3f372006369..fa7ab0934c31cd5d0ce0c18c367da6bac7fc236a 100644

--- a/third_party/crashpad/crashpad/util/mach/child_port_handshake_test.cc

+++ b/third_party/crashpad/crashpad/util/mach/child_port_handshake_test.cc

@@ -113,12 +113,12 @@ class ChildPortHandshakeTest : public Multiprocess {

case TestType::kClientChecksIn_SendRight:

case TestType::kTokenIncorrectThenCorrect:

- EXPECT_EQ(bootstrap_port, send_right);

+ EXPECT_EQ(send_right, bootstrap_port);

break;

case TestType::kClientChecksIn_SendOnceRight:

EXPECT_TRUE(send_right.is_valid());

- EXPECT_NE(bootstrap_port, send_right);

+ EXPECT_NE(send_right, bootstrap_port);

break;

case TestType::kClientDoesNotCheckIn:

@@ -219,7 +219,7 @@ class ChildPortHandshakeTest : public Multiprocess {

}

case TestType::kServerDies: {

- ASSERT_EQ(ClientProcess::kParentClient, client_process_);

+ ASSERT_EQ(client_process_, ClientProcess::kParentClient);

ASSERT_FALSE(child_port_handshake_.RunClient(bootstrap_port,

MACH_MSG_TYPE_COPY_SEND));

break;