Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump_test.cc

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump_test.cc
diff --git a/third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump_test.cc b/third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump_test.cc
index 946c1c49b50668943e334e78c78c1746a4a9cae7..cb42c39624ed6f5453e6d9fb7eca01ded8483843 100644
--- a/third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump_test.cc
+++ b/third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump_test.cc
@@ -60,7 +60,7 @@ TEST(ProcessSnapshotMinidump, Empty) {
UUID client_id;
process_snapshot.ClientID(&client_id);
- EXPECT_EQ(UUID(), client_id);
+ EXPECT_EQ(client_id, UUID());
EXPECT_TRUE(process_snapshot.AnnotationsSimpleMap().empty());
}
@@ -167,7 +167,7 @@ TEST(ProcessSnapshotMinidump, ClientID) {
UUID actual_client_id;
process_snapshot.ClientID(&actual_client_id);
- EXPECT_EQ(client_id, actual_client_id);
+ EXPECT_EQ(actual_client_id, client_id);
EXPECT_TRUE(process_snapshot.AnnotationsSimpleMap().empty());
}
@@ -209,10 +209,10 @@ TEST(ProcessSnapshotMinidump, AnnotationsSimpleMap) {
UUID client_id;
process_snapshot.ClientID(&client_id);
- EXPECT_EQ(UUID(), client_id);
+ EXPECT_EQ(client_id, UUID());
const auto annotations_simple_map = process_snapshot.AnnotationsSimpleMap();
- EXPECT_EQ(dictionary, annotations_simple_map);
+ EXPECT_EQ(annotations_simple_map, dictionary);
}
TEST(ProcessSnapshotMinidump, Modules) {
@@ -313,10 +313,10 @@ TEST(ProcessSnapshotMinidump, Modules) {
EXPECT_TRUE(process_snapshot.Initialize(&string_file));
std::vector<const ModuleSnapshot*> modules = process_snapshot.Modules();
- ASSERT_EQ(minidump_module_count, modules.size());
+ ASSERT_EQ(modules.size(), minidump_module_count);
auto annotations_simple_map = modules[0]->AnnotationsSimpleMap();
- EXPECT_EQ(dictionary_0, annotations_simple_map);
+ EXPECT_EQ(annotations_simple_map, dictionary_0);
auto annotations_vector = modules[0]->AnnotationsVector();
EXPECT_TRUE(annotations_vector.empty());
@@ -328,10 +328,10 @@ TEST(ProcessSnapshotMinidump, Modules) {
EXPECT_TRUE(annotations_vector.empty());
annotations_simple_map = modules[2]->AnnotationsSimpleMap();
- EXPECT_EQ(dictionary_2, annotations_simple_map);
+ EXPECT_EQ(annotations_simple_map, dictionary_2);
annotations_vector = modules[2]->AnnotationsVector();
- EXPECT_EQ(list_annotations_2, annotations_vector);
+ EXPECT_EQ(annotations_vector, list_annotations_2);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698