Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_rva_list_writer_test.cc

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/minidump/minidump_rva_list_writer_test.cc
diff --git a/third_party/crashpad/crashpad/minidump/minidump_rva_list_writer_test.cc b/third_party/crashpad/crashpad/minidump/minidump_rva_list_writer_test.cc
index 4d0d051d76238c490659d5a3c694d75054db8ffd..1d26b27b7f65bc8c66a21ee8114379c7a84c912d 100644
--- a/third_party/crashpad/crashpad/minidump/minidump_rva_list_writer_test.cc
+++ b/third_party/crashpad/crashpad/minidump/minidump_rva_list_writer_test.cc
@@ -48,7 +48,7 @@ TEST(MinidumpRVAListWriter, Empty) {
StringFile string_file;
ASSERT_TRUE(list_writer.WriteEverything(&string_file));
- EXPECT_EQ(sizeof(MinidumpRVAList), string_file.string().size());
+ EXPECT_EQ(string_file.string().size(), sizeof(MinidumpRVAList));
const MinidumpRVAList* list = MinidumpRVAListAtStart(string_file.string(), 0);
ASSERT_TRUE(list);
@@ -70,7 +70,7 @@ TEST(MinidumpRVAListWriter, OneChild) {
const uint32_t* child = MinidumpWritableAtRVA<uint32_t>(
string_file.string(), list->children[0]);
ASSERT_TRUE(child);
- EXPECT_EQ(kValue, *child);
+ EXPECT_EQ(*child, kValue);
}
TEST(MinidumpRVAListWriter, ThreeChildren) {
@@ -96,7 +96,7 @@ TEST(MinidumpRVAListWriter, ThreeChildren) {
const uint32_t* child = MinidumpWritableAtRVA<uint32_t>(
string_file.string(), list->children[index]);
ASSERT_TRUE(child);
- EXPECT_EQ(kValues[index], *child);
+ EXPECT_EQ(*child, kValues[index]);
}
}

Powered by Google App Engine
This is Rietveld 408576698