Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1983)

Unified Diff: third_party/crashpad/crashpad/util/stdlib/string_number_conversion_test.cc

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/stdlib/string_number_conversion_test.cc
diff --git a/third_party/crashpad/crashpad/util/stdlib/string_number_conversion_test.cc b/third_party/crashpad/crashpad/util/stdlib/string_number_conversion_test.cc
index c455a38d5a0e1b7bab3e327110cfbad24499adce..f6634d0f050586f69d5d10d2d93db5e957ea96ab 100644
--- a/third_party/crashpad/crashpad/util/stdlib/string_number_conversion_test.cc
+++ b/third_party/crashpad/crashpad/util/stdlib/string_number_conversion_test.cc
@@ -101,7 +101,7 @@ TEST(StringNumberConversion, StringToInt) {
EXPECT_TRUE(valid) << "index " << index << ", string "
<< kTestData[index].string;
if (valid) {
- EXPECT_EQ(kTestData[index].value, value)
+ EXPECT_EQ(value, kTestData[index].value)
<< "index " << index << ", string " << kTestData[index].string;
}
} else {
@@ -120,7 +120,7 @@ TEST(StringNumberConversion, StringToInt) {
// Ensure that a NUL is not required at the end of the string.
EXPECT_TRUE(StringToNumber(base::StringPiece("66", 1), &output));
- EXPECT_EQ(6, output);
+ EXPECT_EQ(output, 6);
}
TEST(StringNumberConversion, StringToUnsignedInt) {
@@ -199,7 +199,7 @@ TEST(StringNumberConversion, StringToUnsignedInt) {
EXPECT_TRUE(valid) << "index " << index << ", string "
<< kTestData[index].string;
if (valid) {
- EXPECT_EQ(kTestData[index].value, value)
+ EXPECT_EQ(value, kTestData[index].value)
<< "index " << index << ", string " << kTestData[index].string;
}
} else {
@@ -218,7 +218,7 @@ TEST(StringNumberConversion, StringToUnsignedInt) {
// Ensure that a NUL is not required at the end of the string.
EXPECT_TRUE(StringToNumber(base::StringPiece("66", 1), &output));
- EXPECT_EQ(6u, output);
+ EXPECT_EQ(output, 6u);
}
TEST(StringNumberConversion, StringToInt64) {
@@ -260,7 +260,7 @@ TEST(StringNumberConversion, StringToInt64) {
EXPECT_TRUE(valid) << "index " << index << ", string "
<< kTestData[index].string;
if (valid) {
- EXPECT_EQ(kTestData[index].value, value)
+ EXPECT_EQ(value, kTestData[index].value)
<< "index " << index << ", string " << kTestData[index].string;
}
} else {
@@ -310,7 +310,7 @@ TEST(StringNumberConversion, StringToUnsignedInt64) {
EXPECT_TRUE(valid) << "index " << index << ", string "
<< kTestData[index].string;
if (valid) {
- EXPECT_EQ(kTestData[index].value, value)
+ EXPECT_EQ(value, kTestData[index].value)
<< "index " << index << ", string " << kTestData[index].string;
}
} else {

Powered by Google App Engine
This is Rietveld 408576698