Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: third_party/crashpad/crashpad/util/numeric/checked_range_test.cc

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/numeric/checked_range_test.cc
diff --git a/third_party/crashpad/crashpad/util/numeric/checked_range_test.cc b/third_party/crashpad/crashpad/util/numeric/checked_range_test.cc
index 0b1ea32e645d7d3aad68c1c39dc2549002beca8f..404b9898e18234a05505a90f37681e2ba09e0b55 100644
--- a/third_party/crashpad/crashpad/util/numeric/checked_range_test.cc
+++ b/third_party/crashpad/crashpad/util/numeric/checked_range_test.cc
@@ -87,7 +87,7 @@ TEST(CheckedRange, IsValid) {
testcase.size));
CheckedRange<uint32_t> range(testcase.base, testcase.size);
- EXPECT_EQ(testcase.valid, range.IsValid());
+ EXPECT_EQ(range.IsValid(), testcase.valid);
}
const int32_t kMinInt32 = std::numeric_limits<int32_t>::min();
@@ -149,7 +149,7 @@ TEST(CheckedRange, IsValid) {
testcase.size));
CheckedRange<int32_t, uint32_t> range(testcase.base, testcase.size);
- EXPECT_EQ(testcase.valid, range.IsValid());
+ EXPECT_EQ(range.IsValid(), testcase.valid);
}
}
@@ -191,7 +191,7 @@ TEST(CheckedRange, ContainsValue) {
SCOPED_TRACE(base::StringPrintf(
"index %" PRIuS ", value 0x%x", index, testcase.value));
- EXPECT_EQ(testcase.contains, parent_range.ContainsValue(testcase.value));
+ EXPECT_EQ(parent_range.ContainsValue(testcase.value), testcase.contains);
}
}
@@ -243,7 +243,7 @@ TEST(CheckedRange, ContainsRange) {
CheckedRange<uint32_t> child_range(testcase.base, testcase.size);
ASSERT_TRUE(child_range.IsValid());
- EXPECT_EQ(testcase.contains, parent_range.ContainsRange(child_range));
+ EXPECT_EQ(parent_range.ContainsRange(child_range), testcase.contains);
}
}
@@ -296,7 +296,7 @@ TEST(CheckedRange, OverlapsRange) {
CheckedRange<uint32_t> second_range(testcase.base, testcase.size);
ASSERT_TRUE(second_range.IsValid());
- EXPECT_EQ(testcase.overlaps, first_range.OverlapsRange(second_range));
+ EXPECT_EQ(first_range.OverlapsRange(second_range), testcase.overlaps);
}
}

Powered by Google App Engine
This is Rietveld 408576698