Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/crashpad/crashpad/util/synchronization/semaphore_test.cc

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/synchronization/semaphore_test.cc
diff --git a/third_party/crashpad/crashpad/util/synchronization/semaphore_test.cc b/third_party/crashpad/crashpad/util/synchronization/semaphore_test.cc
index 5f0563a61dfc49f81a0152a0e0b27d4c0c729753..fb4338c05ba0a8406bc4b3dbff89fab6844d0af9 100644
--- a/third_party/crashpad/crashpad/util/synchronization/semaphore_test.cc
+++ b/third_party/crashpad/crashpad/util/synchronization/semaphore_test.cc
@@ -73,20 +73,20 @@ ThreadMain(void* argument) {
void StartThread(ThreadMainInfo* info) {
#if defined(OS_POSIX)
int rv = pthread_create(&info->pthread, nullptr, ThreadMain, info);
- ASSERT_EQ(0, rv) << "pthread_create";
+ ASSERT_EQ(rv, 0) << "pthread_create";
#elif defined(OS_WIN)
info->thread = CreateThread(nullptr, 0, ThreadMain, info, 0, nullptr);
- ASSERT_NE(nullptr, info->thread) << "CreateThread";
+ ASSERT_NE(info->thread, nullptr) << "CreateThread";
#endif // OS_POSIX
}
void JoinThread(ThreadMainInfo* info) {
#if defined(OS_POSIX)
int rv = pthread_join(info->pthread, nullptr);
- EXPECT_EQ(0, rv) << "pthread_join";
+ EXPECT_EQ(rv, 0) << "pthread_join";
#elif defined(OS_WIN)
DWORD result = WaitForSingleObject(info->thread, INFINITE);
- EXPECT_EQ(WAIT_OBJECT_0, result) << "WaitForSingleObject";
+ EXPECT_EQ(result, WAIT_OBJECT_0) << "WaitForSingleObject";
#endif // OS_POSIX
}

Powered by Google App Engine
This is Rietveld 408576698