Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8

third_party/crashpad/crashpad/snapshot/minidump/process_snapshot_minidump_test.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 42 matching lines @@
   header.Signature = MINIDUMP_SIGNATURE;
   header.Version = MINIDUMP_VERSION;
 
   EXPECT_TRUE(string_file.Write(&header, sizeof(header)));
 
   ProcessSnapshotMinidump process_snapshot;
   EXPECT_TRUE(process_snapshot.Initialize(&string_file));
 
   UUID client_id;
   process_snapshot.ClientID(&client_id);
-  EXPECT_EQ(UUID(), client_id);
+  EXPECT_EQ(client_id, UUID());
 
   EXPECT_TRUE(process_snapshot.AnnotationsSimpleMap().empty());
 }
 
 // Writes |string| to |writer| as a MinidumpUTF8String, and returns the file
 // offst of the beginning of the string.
 RVA WriteString(FileWriterInterface* writer, const std::string& string) {
   RVA rva = static_cast<RVA>(writer->SeekGet());
 
   uint32_t string_size = static_cast<uint32_t>(string.size());
@@ skipping 86 matching lines @@
   header.Version = MINIDUMP_VERSION;
   header.NumberOfStreams = 1;
   EXPECT_TRUE(string_file.SeekSet(0));
   EXPECT_TRUE(string_file.Write(&header, sizeof(header)));
 
   ProcessSnapshotMinidump process_snapshot;
   EXPECT_TRUE(process_snapshot.Initialize(&string_file));
 
   UUID actual_client_id;
   process_snapshot.ClientID(&actual_client_id);
-  EXPECT_EQ(client_id, actual_client_id);
+  EXPECT_EQ(actual_client_id, client_id);
 
   EXPECT_TRUE(process_snapshot.AnnotationsSimpleMap().empty());
 }
 
 TEST(ProcessSnapshotMinidump, AnnotationsSimpleMap) {
   StringFile string_file;
 
   MINIDUMP_HEADER header = {};
   EXPECT_TRUE(string_file.Write(&header, sizeof(header)));
 
@@ skipping 21 matching lines @@
   header.Version = MINIDUMP_VERSION;
   header.NumberOfStreams = 1;
   EXPECT_TRUE(string_file.SeekSet(0));
   EXPECT_TRUE(string_file.Write(&header, sizeof(header)));
 
   ProcessSnapshotMinidump process_snapshot;
   EXPECT_TRUE(process_snapshot.Initialize(&string_file));
 
   UUID client_id;
   process_snapshot.ClientID(&client_id);
-  EXPECT_EQ(UUID(), client_id);
+  EXPECT_EQ(client_id, UUID());
 
   const auto annotations_simple_map = process_snapshot.AnnotationsSimpleMap();
-  EXPECT_EQ(dictionary, annotations_simple_map);
+  EXPECT_EQ(annotations_simple_map, dictionary);
 }
 
 TEST(ProcessSnapshotMinidump, Modules) {
   StringFile string_file;
 
   MINIDUMP_HEADER header = {};
   EXPECT_TRUE(string_file.Write(&header, sizeof(header)));
 
   MINIDUMP_MODULE minidump_module = {};
   uint32_t minidump_module_count = 3;
@@ skipping 80 matching lines @@
   header.Signature = MINIDUMP_SIGNATURE;
   header.Version = MINIDUMP_VERSION;
   header.NumberOfStreams = 2;
   EXPECT_TRUE(string_file.SeekSet(0));
   EXPECT_TRUE(string_file.Write(&header, sizeof(header)));
 
   ProcessSnapshotMinidump process_snapshot;
   EXPECT_TRUE(process_snapshot.Initialize(&string_file));
 
   std::vector<const ModuleSnapshot*> modules = process_snapshot.Modules();
-  ASSERT_EQ(minidump_module_count, modules.size());
+  ASSERT_EQ(modules.size(), minidump_module_count);
 
   auto annotations_simple_map = modules[0]->AnnotationsSimpleMap();
-  EXPECT_EQ(dictionary_0, annotations_simple_map);
+  EXPECT_EQ(annotations_simple_map, dictionary_0);
 
   auto annotations_vector = modules[0]->AnnotationsVector();
   EXPECT_TRUE(annotations_vector.empty());
 
   annotations_simple_map = modules[1]->AnnotationsSimpleMap();
   EXPECT_TRUE(annotations_simple_map.empty());
 
   annotations_vector = modules[1]->AnnotationsVector();
   EXPECT_TRUE(annotations_vector.empty());
 
   annotations_simple_map = modules[2]->AnnotationsSimpleMap();
-  EXPECT_EQ(dictionary_2, annotations_simple_map);
+  EXPECT_EQ(annotations_simple_map, dictionary_2);
 
   annotations_vector = modules[2]->AnnotationsVector();
-  EXPECT_EQ(list_annotations_2, annotations_vector);
+  EXPECT_EQ(annotations_vector, list_annotations_2);
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad