third_party/crashpad/crashpad/minidump/test/minidump_file_writer_test_util.cc - Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/minidump/test/minidump_file_writer_test_util.cc

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/minidump/test/minidump_context_test_util.cc ('k') | third_party/crashpad/crashpad/minidump/test/minidump_memory_writer_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/minidump/test/minidump_file_writer_test_util.cc

diff --git a/third_party/crashpad/crashpad/minidump/test/minidump_file_writer_test_util.cc b/third_party/crashpad/crashpad/minidump/test/minidump_file_writer_test_util.cc

index 723e97d08338fb73f6872667e19cb23ebcb12e68..f372212bc405998f192a67058cb5c080f7bdc8ca 100644

--- a/third_party/crashpad/crashpad/minidump/test/minidump_file_writer_test_util.cc

+++ b/third_party/crashpad/crashpad/minidump/test/minidump_file_writer_test_util.cc

@@ -48,11 +48,11 @@ void VerifyMinidumpHeader(const MINIDUMP_HEADER* header,

uint32_t streams,

uint32_t timestamp) {

ASSERT_TRUE(header);

- ASSERT_EQ(streams, header->NumberOfStreams);

- ASSERT_EQ(streams ? sizeof(MINIDUMP_HEADER) : 0u, header->StreamDirectoryRva);

- EXPECT_EQ(0u, header->CheckSum);

- EXPECT_EQ(timestamp, header->TimeDateStamp);

- EXPECT_EQ(MiniDumpNormal, header->Flags);

+ ASSERT_EQ(header->NumberOfStreams, streams);

+ ASSERT_EQ(header->StreamDirectoryRva, streams ? sizeof(MINIDUMP_HEADER) : 0u);

+ EXPECT_EQ(header->CheckSum, 0u);

+ EXPECT_EQ(header->TimeDateStamp, timestamp);

+ EXPECT_EQ(header->Flags, MiniDumpNormal);

}

} // namespace test