third_party/crashpad/crashpad/minidump/minidump_context_writer_test.cc - Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_context_writer_test.cc

Issue 2804713002: Update Crashpad to b4095401639ebe2ad33169e5c1d994065cbff1b8 (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/handler/win/crashy_test_z7_loader.cc ('k') | third_party/crashpad/crashpad/minidump/minidump_crashpad_info_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/minidump/minidump_context_writer_test.cc

diff --git a/third_party/crashpad/crashpad/minidump/minidump_context_writer_test.cc b/third_party/crashpad/crashpad/minidump/minidump_context_writer_test.cc

index 048d1df356a42c436fe6a2a6794aba7089cafde5..a6b5f3a9b428180d1f5b2568a21652c902606971 100644

--- a/third_party/crashpad/crashpad/minidump/minidump_context_writer_test.cc

+++ b/third_party/crashpad/crashpad/minidump/minidump_context_writer_test.cc

@@ -39,7 +39,7 @@ TEST(MinidumpContextWriter, MinidumpContextX86Writer) {

MinidumpContextX86Writer context_writer;

EXPECT_TRUE(context_writer.WriteEverything(&string_file));

- ASSERT_EQ(sizeof(MinidumpContextX86), string_file.string().size());

+ ASSERT_EQ(string_file.string().size(), sizeof(MinidumpContextX86));

const MinidumpContextX86* observed =

MinidumpWritableAtRVA<MinidumpContextX86>(string_file.string(), 0);

@@ -58,7 +58,7 @@ TEST(MinidumpContextWriter, MinidumpContextX86Writer) {

InitializeMinidumpContextX86(context_writer.context(), kSeed);

EXPECT_TRUE(context_writer.WriteEverything(&string_file));

- ASSERT_EQ(sizeof(MinidumpContextX86), string_file.string().size());

+ ASSERT_EQ(string_file.string().size(), sizeof(MinidumpContextX86));

const MinidumpContextX86* observed =

MinidumpWritableAtRVA<MinidumpContextX86>(string_file.string(), 0);

@@ -79,7 +79,7 @@ TEST(MinidumpContextWriter, MinidumpContextAMD64Writer) {

MinidumpContextAMD64Writer context_writer;

EXPECT_TRUE(context_writer.WriteEverything(&string_file));

- ASSERT_EQ(sizeof(MinidumpContextAMD64), string_file.string().size());

+ ASSERT_EQ(string_file.string().size(), sizeof(MinidumpContextAMD64));

const MinidumpContextAMD64* observed =

MinidumpWritableAtRVA<MinidumpContextAMD64>(string_file.string(), 0);

@@ -98,7 +98,7 @@ TEST(MinidumpContextWriter, MinidumpContextAMD64Writer) {

InitializeMinidumpContextAMD64(context_writer.context(), kSeed);

EXPECT_TRUE(context_writer.WriteEverything(&string_file));

- ASSERT_EQ(sizeof(MinidumpContextAMD64), string_file.string().size());

+ ASSERT_EQ(string_file.string().size(), sizeof(MinidumpContextAMD64));

const MinidumpContextAMD64* observed =

MinidumpWritableAtRVA<MinidumpContextAMD64>(string_file.string(), 0);