Avoid using declarations in headers which introduce symbol conflicts.

Avoid using declarations in headers which introduce symbol conflicts.

Source/modules/fetch/Response.h defines class blink::Response.
Source/core/inspector/InspectorBaseAgent.h was pulling blink::protocol::Response
into the blink namespace.  Any file transitively #including both of these
triggered a symbol redefinition error on Windows.

Instead, explicitly qualify protocol::Response in inspector headers, then add
using directives in .cpp files.

BUG=699477
TEST=none

Review-Url: https://codereview.chromium.org/2738453004
Cr-Commit-Position: refs/heads/master@{#455471}
Committed: https://chromium.googlesource.com/chromium/src/+/665bde1047fbd03398ec00158218cd56a60f1e35

[Peter Kasting, 2017-03-08 11:04:11]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 11:04:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-03-08 11:07:36]

pkasting@chromium.org changed reviewers:
+ dgozman@chromium.org

[Peter Kasting, 2017-03-08 11:07:37]

Despite the size of this patch, it should be mechanical.  The real review
questions are:

* Is this for some reason a bad idea, and if so, how do we avoid the symbol
conflict
* Are the .cpp using directives in the right place (not all files agree on
whether to place them inside or outside the blink namespace, I followed existing
style if present and otherwise placed them inside)

[Peter Kasting, 2017-03-08 11:48:49]

BTW, if this looks good to you, please CQ+.

[commit-bot: I haz the power, 2017-03-08 13:26:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 13:26:31]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2017-03-08 16:38:01]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2017-03-08 16:38:01]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-03-08 16:38:01]

lgtm

[commit-bot: I haz the power, 2017-03-08 16:38:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 16:44:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488991081386720, "parent_rev":
"396fddbbebaa3e693fdcf2b6f6fd26a110fcda3e", "commit_rev":
"665bde1047fbd03398ec00158218cd56a60f1e35"}

[commit-bot: I haz the power, 2017-03-08 16:45:19]

Description was changed from

==========
Avoid using declarations in headers which introduce symbol conflicts.

Source/modules/fetch/Response.h defines class blink::Response.
Source/core/inspector/InspectorBaseAgent.h was pulling blink::protocol::Response
into the blink namespace.  Any file transitively #including both of these
triggered a symbol redefinition error on Windows.

Instead, explicitly qualify protocol::Response in inspector headers, then add
using directives in .cpp files.

BUG=699477
TEST=none
==========

to

==========
Avoid using declarations in headers which introduce symbol conflicts.

Source/modules/fetch/Response.h defines class blink::Response.
Source/core/inspector/InspectorBaseAgent.h was pulling blink::protocol::Response
into the blink namespace.  Any file transitively #including both of these
triggered a symbol redefinition error on Windows.

Instead, explicitly qualify protocol::Response in inspector headers, then add
using directives in .cpp files.

BUG=699477
TEST=none

Review-Url: https://codereview.chromium.org/2738453004
Cr-Commit-Position: refs/heads/master@{#455471}
Committed:
https://chromium.googlesource.com/chromium/src/+/665bde1047fbd03398ec00158218...
==========

[commit-bot: I haz the power, 2017-03-08 16:45:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/665bde1047fbd03398ec00158218...