Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h
index a1d7406b38148b2c452ff53aca15a841fec622ca..c853444eb4c1f52b46cbded4bc3e70d6b0acd6d9 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h
@@ -70,29 +70,30 @@ class CORE_EXPORT InspectorLayerTreeAgent final
void didPaint(const GraphicsLayer*, GraphicsContext&, const LayoutRect&);
// Called from the front-end.
- Response enable() override;
- Response disable() override;
- Response compositingReasons(
+ protocol::Response enable() override;
+ protocol::Response disable() override;
+ protocol::Response compositingReasons(
const String& layerId,
std::unique_ptr<protocol::Array<String>>* compositingReasons) override;
- Response makeSnapshot(const String& layerId, String* snapshotId) override;
- Response loadSnapshot(
+ protocol::Response makeSnapshot(const String& layerId,
+ String* snapshotId) override;
+ protocol::Response loadSnapshot(
std::unique_ptr<protocol::Array<protocol::LayerTree::PictureTile>> tiles,
String* snapshotId) override;
- Response releaseSnapshot(const String& snapshotId) override;
- Response profileSnapshot(
+ protocol::Response releaseSnapshot(const String& snapshotId) override;
+ protocol::Response profileSnapshot(
const String& snapshotId,
- Maybe<int> minRepeatCount,
- Maybe<double> minDuration,
- Maybe<protocol::DOM::Rect> clipRect,
+ protocol::Maybe<int> minRepeatCount,
+ protocol::Maybe<double> minDuration,
+ protocol::Maybe<protocol::DOM::Rect> clipRect,
std::unique_ptr<protocol::Array<protocol::Array<double>>>* timings)
override;
- Response replaySnapshot(const String& snapshotId,
- Maybe<int> fromStep,
- Maybe<int> toStep,
- Maybe<double> scale,
- String* dataURL) override;
- Response snapshotCommandLog(
+ protocol::Response replaySnapshot(const String& snapshotId,
+ protocol::Maybe<int> fromStep,
+ protocol::Maybe<int> toStep,
+ protocol::Maybe<double> scale,
+ String* dataURL) override;
+ protocol::Response snapshotCommandLog(
const String& snapshotId,
std::unique_ptr<protocol::Array<protocol::DictionaryValue>>* commandLog)
override;
@@ -108,8 +109,9 @@ class CORE_EXPORT InspectorLayerTreeAgent final
GraphicsLayer* rootGraphicsLayer();
PaintLayerCompositor* paintLayerCompositor();
- Response layerById(const String& layerId, GraphicsLayer*&);
- Response snapshotById(const String& snapshotId, const PictureSnapshot*&);
+ protocol::Response layerById(const String& layerId, GraphicsLayer*&);
+ protocol::Response snapshotById(const String& snapshotId,
+ const PictureSnapshot*&);
typedef HashMap<int, int> LayerIdToNodeIdMap;
void buildLayerIdToNodeIdMap(PaintLayer*, LayerIdToNodeIdMap&);

Powered by Google App Engine
This is Rietveld 408576698