Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
index a3017299ce1792113f79f0e0b99f546ec859d4a5..dff48c75062943cc76cf1b34117d3cb577afaf8a 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
@@ -193,30 +193,31 @@ class CORE_EXPORT InspectorNetworkAgent final
void didReceiveWebSocketFrameError(unsigned long identifier, const String&);
// Called from frontend
- Response enable(Maybe<int> totalBufferSize,
- Maybe<int> resourceBufferSize) override;
- Response disable() override;
- Response setUserAgentOverride(const String&) override;
- Response setExtraHTTPHeaders(
+ protocol::Response enable(Maybe<int> totalBufferSize,
+ Maybe<int> resourceBufferSize) override;
+ protocol::Response disable() override;
+ protocol::Response setUserAgentOverride(const String&) override;
+ protocol::Response setExtraHTTPHeaders(
std::unique_ptr<protocol::Network::Headers>) override;
void getResponseBody(const String& requestId,
std::unique_ptr<GetResponseBodyCallback>) override;
- Response addBlockedURL(const String& url) override;
- Response removeBlockedURL(const String& url) override;
- Response replayXHR(const String& requestId) override;
- Response setMonitoringXHREnabled(bool) override;
- Response canClearBrowserCache(bool* result) override;
- Response canClearBrowserCookies(bool* result) override;
- Response emulateNetworkConditions(bool offline,
- double latency,
- double downloadThroughput,
- double uploadThroughput,
- Maybe<String> connectionType) override;
- Response setCacheDisabled(bool) override;
- Response setBypassServiceWorker(bool) override;
- Response setDataSizeLimitsForTest(int maxTotalSize,
- int maxResourceSize) override;
- Response getCertificate(
+ protocol::Response addBlockedURL(const String& url) override;
+ protocol::Response removeBlockedURL(const String& url) override;
+ protocol::Response replayXHR(const String& requestId) override;
+ protocol::Response setMonitoringXHREnabled(bool) override;
+ protocol::Response canClearBrowserCache(bool* result) override;
+ protocol::Response canClearBrowserCookies(bool* result) override;
+ protocol::Response emulateNetworkConditions(
+ bool offline,
+ double latency,
+ double downloadThroughput,
+ double uploadThroughput,
+ Maybe<String> connectionType) override;
+ protocol::Response setCacheDisabled(bool) override;
+ protocol::Response setBypassServiceWorker(bool) override;
+ protocol::Response setDataSizeLimitsForTest(int maxTotalSize,
+ int maxResourceSize) override;
+ protocol::Response getCertificate(
const String& origin,
std::unique_ptr<protocol::Array<String>>* certificate) override;

Powered by Google App Engine
This is Rietveld 408576698