Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
index 608ef9202afc1579863a211e8b89392296e8d86b..31e08dbea5904ee73bd1d7eda40da746cb58bfb4 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
@@ -72,20 +72,25 @@ class CORE_EXPORT InspectorDOMDebuggerAgent final
DECLARE_VIRTUAL_TRACE();
// DOMDebugger API for frontend
- Response setDOMBreakpoint(int nodeId, const String& type) override;
- Response removeDOMBreakpoint(int nodeId, const String& type) override;
- Response setEventListenerBreakpoint(const String& eventName,
- Maybe<String> targetName) override;
- Response removeEventListenerBreakpoint(const String& eventName,
- Maybe<String> targetName) override;
- Response setInstrumentationBreakpoint(const String& eventName) override;
- Response removeInstrumentationBreakpoint(const String& eventName) override;
- Response setXHRBreakpoint(const String& url) override;
- Response removeXHRBreakpoint(const String& url) override;
- Response getEventListeners(
+ protocol::Response setDOMBreakpoint(int nodeId, const String& type) override;
+ protocol::Response removeDOMBreakpoint(int nodeId,
+ const String& type) override;
+ protocol::Response setEventListenerBreakpoint(
+ const String& eventName,
+ protocol::Maybe<String> targetName) override;
+ protocol::Response removeEventListenerBreakpoint(
+ const String& eventName,
+ protocol::Maybe<String> targetName) override;
+ protocol::Response setInstrumentationBreakpoint(
+ const String& eventName) override;
+ protocol::Response removeInstrumentationBreakpoint(
+ const String& eventName) override;
+ protocol::Response setXHRBreakpoint(const String& url) override;
+ protocol::Response removeXHRBreakpoint(const String& url) override;
+ protocol::Response getEventListeners(
const String& objectId,
- Maybe<int> depth,
- Maybe<bool> pierce,
+ protocol::Maybe<int> depth,
+ protocol::Maybe<bool> pierce,
std::unique_ptr<protocol::Array<protocol::DOMDebugger::EventListener>>*
listeners) override;
@@ -108,7 +113,7 @@ class CORE_EXPORT InspectorDOMDebuggerAgent final
void did(const probe::UserCallback&);
void breakableLocation(const char* name);
- Response disable() override;
+ protocol::Response disable() override;
void restore() override;
void didCommitLoadForLocalFrame(LocalFrame*) override;
@@ -135,8 +140,10 @@ class CORE_EXPORT InspectorDOMDebuggerAgent final
void breakProgramOnDOMEvent(Node* target, int breakpointType, bool insertion);
void updateSubtreeBreakpoints(Node*, uint32_t rootMask, bool set);
bool hasBreakpoint(Node*, int type);
- Response setBreakpoint(const String& eventName, const String& targetName);
- Response removeBreakpoint(const String& eventName, const String& targetName);
+ protocol::Response setBreakpoint(const String& eventName,
+ const String& targetName);
+ protocol::Response removeBreakpoint(const String& eventName,
+ const String& targetName);
void didAddBreakpoint();
void didRemoveBreakpoint();

Powered by Google App Engine
This is Rietveld 408576698