Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: third_party/WebKit/Source/core/inspector/DOMEditor.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/DOMEditor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/DOMEditor.h
diff --git a/third_party/WebKit/Source/core/inspector/DOMEditor.h b/third_party/WebKit/Source/core/inspector/DOMEditor.h
index 28cb1dcdb5cb8d78773f7018ba5bf84c4efbd067..93555f22d12be08421a7ba95bcda57f50462d75d 100644
--- a/third_party/WebKit/Source/core/inspector/DOMEditor.h
+++ b/third_party/WebKit/Source/core/inspector/DOMEditor.h
@@ -43,7 +43,6 @@ class ExceptionState;
class InspectorHistory;
class Node;
class Text;
-using protocol::Response;
class DOMEditor final : public GarbageCollected<DOMEditor> {
WTF_MAKE_NONCOPYABLE(DOMEditor);
@@ -71,12 +70,16 @@ class DOMEditor final : public GarbageCollected<DOMEditor> {
ExceptionState&);
bool setNodeValue(Node* parentNode, const String& value, ExceptionState&);
- Response insertBefore(ContainerNode* parentNode, Node*, Node* anchorNode);
- Response removeChild(ContainerNode* parentNode, Node*);
- Response setAttribute(Element*, const String& name, const String& value);
- Response removeAttribute(Element*, const String& name);
- Response setOuterHTML(Node*, const String& html, Node** newNode);
- Response replaceWholeText(Text*, const String& text);
+ protocol::Response insertBefore(ContainerNode* parentNode,
+ Node*,
+ Node* anchorNode);
+ protocol::Response removeChild(ContainerNode* parentNode, Node*);
+ protocol::Response setAttribute(Element*,
+ const String& name,
+ const String& value);
+ protocol::Response removeAttribute(Element*, const String& name);
+ protocol::Response setOuterHTML(Node*, const String& html, Node** newNode);
+ protocol::Response replaceWholeText(Text*, const String& text);
private:
class DOMAction;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/DOMEditor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698