Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/device_orientation/DeviceOrientationInspectorAgent.h" 5 #include "modules/device_orientation/DeviceOrientationInspectorAgent.h"
6 6
7 #include "core/frame/LocalFrame.h" 7 #include "core/frame/LocalFrame.h"
8 #include "core/inspector/InspectedFrames.h" 8 #include "core/inspector/InspectedFrames.h"
9 #include "modules/device_orientation/DeviceOrientationController.h" 9 #include "modules/device_orientation/DeviceOrientationController.h"
10 #include "modules/device_orientation/DeviceOrientationData.h" 10 #include "modules/device_orientation/DeviceOrientationData.h"
11 #include "wtf/Assertions.h" 11 #include "wtf/Assertions.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 using protocol::Response;
16
15 namespace DeviceOrientationInspectorAgentState { 17 namespace DeviceOrientationInspectorAgentState {
16 static const char alpha[] = "alpha"; 18 static const char alpha[] = "alpha";
17 static const char beta[] = "beta"; 19 static const char beta[] = "beta";
18 static const char gamma[] = "gamma"; 20 static const char gamma[] = "gamma";
19 static const char overrideEnabled[] = "overrideEnabled"; 21 static const char overrideEnabled[] = "overrideEnabled";
20 } 22 }
21 23
22 DeviceOrientationInspectorAgent::~DeviceOrientationInspectorAgent() {} 24 DeviceOrientationInspectorAgent::~DeviceOrientationInspectorAgent() {}
23 25
24 DeviceOrientationInspectorAgent::DeviceOrientationInspectorAgent( 26 DeviceOrientationInspectorAgent::DeviceOrientationInspectorAgent(
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 void DeviceOrientationInspectorAgent::didCommitLoadForLocalFrame( 88 void DeviceOrientationInspectorAgent::didCommitLoadForLocalFrame(
87 LocalFrame* frame) { 89 LocalFrame* frame) {
88 if (frame == m_inspectedFrames->root()) { 90 if (frame == m_inspectedFrames->root()) {
89 // New document in main frame - apply override there. 91 // New document in main frame - apply override there.
90 // No need to cleanup previous one, as it's already gone. 92 // No need to cleanup previous one, as it's already gone.
91 restore(); 93 restore();
92 } 94 }
93 } 95 }
94 96
95 } // namespace blink 97 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698