Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h b/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h
index 7d4f9b33bb1793bd328df2d46fda5181456d4c34..6155d490d18b504e1ff74a0c403e20502830d064 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h
@@ -51,21 +51,21 @@ class CORE_EXPORT InspectorApplicationCacheAgent final
// InspectorBaseAgent
void restore() override;
- Response disable() override;
+ protocol::Response disable() override;
// InspectorInstrumentation API
void updateApplicationCacheStatus(LocalFrame*);
void networkStateChanged(LocalFrame*, bool online);
// ApplicationCache API for frontend
- Response getFramesWithManifests(
+ protocol::Response getFramesWithManifests(
std::unique_ptr<
protocol::Array<protocol::ApplicationCache::FrameWithManifest>>*
frameIds) override;
- Response enable() override;
- Response getManifestForFrame(const String& frameId,
- String* manifestURL) override;
- Response getApplicationCacheForFrame(
+ protocol::Response enable() override;
+ protocol::Response getManifestForFrame(const String& frameId,
+ String* manifestURL) override;
+ protocol::Response getApplicationCacheForFrame(
const String& frameId,
std::unique_ptr<protocol::ApplicationCache::ApplicationCache>*) override;
@@ -83,7 +83,8 @@ class CORE_EXPORT InspectorApplicationCacheAgent final
buildObjectForApplicationCacheResource(
const ApplicationCacheHost::ResourceInfo&);
- Response assertFrameWithDocumentLoader(String frameId, DocumentLoader*&);
+ protocol::Response assertFrameWithDocumentLoader(String frameId,
+ DocumentLoader*&);
Member<InspectedFrames> m_inspectedFrames;
};

Powered by Google App Engine
This is Rietveld 408576698