third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h - Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp ('k') | third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

diff --git a/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h b/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

index 20ee21f3b1c776d4bcc823f23b8ea2b740e0aeac..2ca5d66ae62b8bf60d46aab3f0abd6a7c40a2066 100644

--- a/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

+++ b/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h

@@ -54,13 +54,13 @@ class MODULES_EXPORT InspectorDatabaseAgent final

~InspectorDatabaseAgent() override;

DECLARE_VIRTUAL_TRACE();

- Response disable() override;

+ protocol::Response disable() override;

void restore() override;

void didCommitLoadForLocalFrame(LocalFrame*) override;

// Called from the front-end.

- Response enable() override;

- Response getDatabaseTableNames(

+ protocol::Response enable() override;

+ protocol::Response getDatabaseTableNames(

const String& databaseId,

std::unique_ptr<protocol::Array<String>>* names) override;

void executeSQL(const String& databaseId,