Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h

Issue 2738453004: Avoid using declarations in headers which introduce symbol conflicts. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
index 77a8b11d43466a76c27839460ed62d1ab160d549..578f58e219f377c7e24c4152351f1932f4a6ce79 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
@@ -43,18 +43,18 @@ class CORE_EXPORT InspectorTracingAgent final
// Base agent methods.
void restore() override;
- Response disable() override;
+ protocol::Response disable() override;
// InspectorInstrumentation methods
void frameStartedLoading(LocalFrame*, FrameLoadType);
void frameStoppedLoading(LocalFrame*);
// Protocol method implementations.
- void start(Maybe<String> categories,
- Maybe<String> options,
- Maybe<double> bufferUsageReportingInterval,
- Maybe<String> transferMode,
- Maybe<protocol::Tracing::TraceConfig>,
+ void start(protocol::Maybe<String> categories,
+ protocol::Maybe<String> options,
+ protocol::Maybe<double> bufferUsageReportingInterval,
+ protocol::Maybe<String> transferMode,
+ protocol::Maybe<protocol::Tracing::TraceConfig>,
std::unique_ptr<StartCallback>) override;
void end(std::unique_ptr<EndCallback>) override;

Powered by Google App Engine
This is Rietveld 408576698